Remove relative paths from Husky called from 'prepare' task on npm install and privacy policy version integration to avoid breakage during build on Vercel

Author: webstackdev

.husky/prepare.js

@@ -0,0 +1,30 @@
+#!/usr/bin/env node
+/* eslint-disable no-undef */
+/**
+ * Husky prepare script to install git hooks. It's designed to quiet warnings on
+ * CI environments where .git directory may be missing when "prepare" script runs
+ * (e.g., during "npm install" step).
+ */
+import { existsSync } from 'node:fs'
+import { join } from 'node:path'
+import { execSync } from 'node:child_process'
+
+const projectRoot = process.cwd()
+const gitDirectory = join(projectRoot, '.git')
+
+if (!existsSync(gitDirectory)) {
+  console.warn(`✅ Skipping Husky install: missing .git directory at ${gitDirectory}`)
+  process.exit(0)
+}
+
+try {
+  console.log(`Running Husky install from ${projectRoot}`)
+  execSync('husky', { stdio: 'inherit', cwd: projectRoot })
+  console.log('✅ Husky install complete')
+} catch (error) {
+  console.error('❌ Husky install failed')
+  const status = typeof error === 'object' && error && 'status' in error && typeof error.status === 'number'
+    ? error.status
+    : 1
+  process.exit(status)
+}

package-lock.json

@@ -60,7 +60,7 @@
     "test:e2e:full": "dotenv -e .env.development -- cross-env FORCE_COLOR=1 E2E_MOCKS=1 npx playwright test",
     "test:unit": "FORCE_COLOR=1 npx vitest run",
     "upgrade": "npx @astrojs/upgrade",
-    "prepare": "node -e \"const fs=require('node:fs');if(!fs.existsSync('.git')){console.log('Skipping Husky install (missing .git directory)');process.exit(0);}\" && husky"
+    "prepare": "node .husky/prepare.js"
   },
   "dependencies": {
     "@astrojs/check": "0.9.6",
@@ -158,7 +158,7 @@
     "eslint-import-resolver-typescript": "^4.4.4",
     "eslint-plugin-astro": "1.5.0",
     "eslint-plugin-import": "2.32.0",
-    "eslint-plugin-jsdoc": "61.4.1",
+    "eslint-plugin-jsdoc": "61.4.2",
     "eslint-plugin-jsx-a11y": "6.10.2",
     "eslint-plugin-security": "3.0.1",
     "eslint-plugin-yml": "1.19.0",

package.json

@@ -1,5 +1,6 @@
 import { describe, it, expect, beforeEach, afterEach, vi } from 'vitest'
 import { execSync } from 'node:child_process'
+import { existsSync } from 'node:fs'
 import { TestError } from '@test/errors'
 
 vi.mock('../../../lib/config/environmentServer', () => ({
@@ -11,6 +12,10 @@ vi.mock('node:child_process', () => ({
   execSync: vi.fn(),
 }))
 
+vi.mock('node:fs', () => ({
+  existsSync: vi.fn(() => true),
+}))
+
 import { getOptionalEnv } from '../../../lib/config/environmentServer'
 
 describe('PrivacyPolicyVersion Integration', () => {
@@ -19,6 +24,7 @@ describe('PrivacyPolicyVersion Integration', () => {
 
   beforeEach(() => {
     vi.mocked(getOptionalEnv).mockReturnValue(undefined)
+    vi.mocked(existsSync).mockReturnValue(true)
 
     consoleLogSpy = vi.spyOn(console, 'log').mockImplementation(() => {})
     consoleWarnSpy = vi.spyOn(console, 'warn').mockImplementation(() => {})
@@ -150,6 +156,35 @@ describe('PrivacyPolicyVersion Integration', () => {
       })
       expect(consoleWarnSpy).toHaveBeenCalled()
     })
+
+    it('skips git lookup entirely when repository metadata is missing', async () => {
+      vi.mocked(existsSync).mockReturnValue(false)
+      vi.useFakeTimers()
+      vi.setSystemTime(new Date('2026-01-15T00:00:00Z'))
+
+      const { privacyPolicyVersion } = await import('../index')
+
+      const mockUpdateConfig = vi.fn()
+      const integration = privacyPolicyVersion()
+
+      await integration.hooks['astro:config:setup']?.({
+        updateConfig: mockUpdateConfig,
+        // @ts-expect-error - Partial mock
+        config: {},
+      })
+
+      expect(execSync).not.toHaveBeenCalled()
+      expect(consoleWarnSpy).toHaveBeenCalledWith(
+        '[privacy-policy-version] Git metadata not found. Skipping git lookup.',
+      )
+      expect(mockUpdateConfig).toHaveBeenCalledWith({
+        vite: {
+          define: {
+            'import.meta.env.PRIVACY_POLICY_VERSION': '"2026-01-15"',
+          },
+        },
+      })
+    })
   })
 
   describe('integration metadata', () => {
@@ -211,5 +246,25 @@ describe('PrivacyPolicyVersion Integration', () => {
         expect.any(Object),
       )
     })
+
+    it('executes git commands from the project root directory', async () => {
+      vi.mocked(execSync).mockReturnValue('2024-03-15')
+
+      const { privacyPolicyVersion } = await import('../index')
+
+      const mockUpdateConfig = vi.fn()
+      const integration = privacyPolicyVersion()
+
+      await integration.hooks['astro:config:setup']?.({
+        updateConfig: mockUpdateConfig,
+        // @ts-expect-error - Partial mock
+        config: {},
+      })
+
+      expect(execSync).toHaveBeenCalledWith(
+        expect.any(String),
+        expect.objectContaining({ cwd: process.cwd() }),
+      )
+    })
   })
 })

src/integrations/PrivacyPolicyVersion/__tests__/index.spec.ts

@@ -15,10 +15,14 @@
  */
 
 import { execSync } from 'node:child_process'
+import { existsSync } from 'node:fs'
+import { join } from 'node:path'
 import type { AstroIntegration } from 'astro'
 import { getOptionalEnv } from '../../lib/config/environmentServer'
 
-const PRIVACY_POLICY_PATH = 'src/pages/privacy/index.astro'
+const PROJECT_ROOT = process.cwd()
+const PRIVACY_POLICY_PATH = join(PROJECT_ROOT, 'src', 'pages', 'privacy', 'index.astro')
+const GIT_DIRECTORY_PATH = join(PROJECT_ROOT, '.git')
 
 export const toIsoDateString = (date: Date): string => date.toISOString().slice(0, 10)
 
@@ -32,7 +36,7 @@ function getPrivacyPolicyVersionFromGit(filePath: string): string | null {
     // Get last commit date for privacy policy file in YYYY-MM-DD format
     const lastCommitDate = execSync(
       `git log -1 --format=%cd --date=format:%Y-%m-%d -- ${filePath}`,
-      { encoding: 'utf-8' },
+      { encoding: 'utf-8', cwd: PROJECT_ROOT },
     ).trim()
 
     if (lastCommitDate) {
@@ -51,6 +55,23 @@ function getPrivacyPolicyVersionFromGit(filePath: string): string | null {
   }
 }
 
+/**
+ * Determine whether git metadata is available before issuing git commands.
+ * Vercel preview builds, for example, do not clone the repo with git history,
+ * so attempting to run git commands will fail immediately. Checking for a git
+ * directory lets us skip the expensive call entirely.
+ */
+function hasGitRepository(): boolean {
+  try {
+    return existsSync(GIT_DIRECTORY_PATH)
+  } catch (error) {
+    console.warn(
+      `[privacy-policy-version] Unable to verify git repository: ${error instanceof Error ? error.message : String(error)}`,
+    )
+    return false
+  }
+}
+
 /**
  * Resolve privacy policy version using env, git metadata, or current date fallback.
  */
@@ -62,10 +83,14 @@ export function resolvePrivacyPolicyVersion(): string {
     return envVersion
   }
 
-  const gitVersion = getPrivacyPolicyVersionFromGit(PRIVACY_POLICY_PATH)
-  if (gitVersion) {
-    console.log(`✅ Privacy policy version set from git: ${gitVersion}`)
-    return gitVersion
+  if (hasGitRepository()) {
+    const gitVersion = getPrivacyPolicyVersionFromGit(PRIVACY_POLICY_PATH)
+    if (gitVersion) {
+      console.log(`✅ Privacy policy version set from git: ${gitVersion}`)
+      return gitVersion
+    }
+  } else {
+    console.warn('[privacy-policy-version] Git metadata not found. Skipping git lookup.')
   }
 
   const fallback = toIsoDateString(new Date())