Fix code lint errors

Author: webstackdev

src/pages/api/gdpr/consent.ts

@@ -12,6 +12,36 @@ export const prerender = false // Force SSR for this endpoint
 
 const ROUTE = '/api/gdpr/consent'
 
+const CONSENT_PURPOSES = ['contact', 'marketing', 'analytics', 'downloads'] as const
+type ConsentPurpose = (typeof CONSENT_PURPOSES)[number]
+
+const CONSENT_SOURCES = ['contact_form', 'newsletter_form', 'download_form', 'cookies_modal', 'preferences_page'] as const
+type ConsentSource = (typeof CONSENT_SOURCES)[number]
+
+const DEFAULT_SOURCE: ConsentSource = 'cookies_modal'
+const DEFAULT_USER_AGENT = 'unknown'
+
+const isConsentPurpose = (value: unknown): value is ConsentPurpose =>
+  typeof value === 'string' && CONSENT_PURPOSES.includes(value as ConsentPurpose)
+
+const isConsentSource = (value: unknown): value is ConsentSource =>
+  typeof value === 'string' && CONSENT_SOURCES.includes(value as ConsentSource)
+
+const sanitizePurposes = (purposes: unknown): ConsentPurpose[] =>
+  Array.isArray(purposes) ? purposes.filter(isConsentPurpose) : []
+
+const sanitizeSource = (source: unknown): ConsentSource => (isConsentSource(source) ? source : DEFAULT_SOURCE)
+
+const normalizeNullableString = (value?: string | null): string | null => {
+  if (typeof value !== 'string') {
+    return null
+  }
+  const trimmed = value.trim()
+  return trimmed.length > 0 ? trimmed : null
+}
+
+const normalizeUserAgent = (value?: string | null): string => normalizeNullableString(value) ?? DEFAULT_USER_AGENT
+
 type ConsentRecordRow = {
   id: string
   data_subject_id: string
@@ -46,33 +76,63 @@ const buildRateLimitError = (reset: number | undefined, message?: string) => {
   })
 }
 
-const mapConsentRecord = (record: ConsentRecordRow): ConsentResponse['record'] => ({
-  id: record.id,
-  DataSubjectId: record.data_subject_id,
-  email: record.email,
-  purposes: record.purposes,
-  timestamp: record.timestamp,
-  source: record.source,
-  userAgent: record.user_agent,
-  ipAddress: record.ip_address,
-  privacyPolicyVersion: record.privacy_policy_version,
-  consentText: record.consent_text,
-  verified: record.verified,
-})
-
-const buildMockConsentRecord = (body: ConsentRequest): ConsentResponse['record'] => ({
-  id: randomUUID(),
-  DataSubjectId: body.DataSubjectId,
-  email: body.email?.toLowerCase().trim() ?? null,
-  purposes: body.purposes,
-  timestamp: new Date().toISOString(),
-  source: body.source ?? null,
-  userAgent: body.userAgent ?? null,
-  ipAddress: body.ipAddress ?? null,
-  privacyPolicyVersion: getPrivacyPolicyVersion(),
-  consentText: body.consentText ?? null,
-  verified: body.verified ?? false,
-})
+const mapConsentRecord = (record: ConsentRecordRow): ConsentResponse['record'] => {
+  const normalizedEmail = normalizeNullableString(record.email)
+  const normalizedIpAddress = normalizeNullableString(record.ip_address)
+  const normalizedConsentText = normalizeNullableString(record.consent_text)
+
+  const mapped: ConsentResponse['record'] = {
+    id: record.id,
+    DataSubjectId: record.data_subject_id,
+    purposes: sanitizePurposes(record.purposes),
+    timestamp: record.timestamp,
+    source: sanitizeSource(record.source),
+    userAgent: normalizeUserAgent(record.user_agent),
+    privacyPolicyVersion: record.privacy_policy_version ?? getPrivacyPolicyVersion(),
+    verified: record.verified,
+  }
+
+  if (normalizedEmail) {
+    mapped.email = normalizedEmail
+  }
+  if (normalizedIpAddress) {
+    mapped.ipAddress = normalizedIpAddress
+  }
+  if (normalizedConsentText) {
+    mapped.consentText = normalizedConsentText
+  }
+
+  return mapped
+}
+
+const buildMockConsentRecord = (body: ConsentRequest): ConsentResponse['record'] => {
+  const normalizedEmail = normalizeNullableString(body.email ?? null)
+  const normalizedIpAddress = normalizeNullableString(body.ipAddress ?? null)
+  const normalizedConsentText = normalizeNullableString(body.consentText ?? null)
+
+  const mockRecord: ConsentResponse['record'] = {
+    id: randomUUID(),
+    DataSubjectId: body.DataSubjectId,
+    purposes: sanitizePurposes(body.purposes),
+    timestamp: new Date().toISOString(),
+    source: sanitizeSource(body.source),
+    userAgent: normalizeUserAgent(body.userAgent),
+    privacyPolicyVersion: getPrivacyPolicyVersion(),
+    verified: body.verified ?? false,
+  }
+
+  if (normalizedEmail) {
+    mockRecord.email = normalizedEmail
+  }
+  if (normalizedIpAddress) {
+    mockRecord.ipAddress = normalizedIpAddress
+  }
+  if (normalizedConsentText) {
+    mockRecord.consentText = normalizedConsentText
+  }
+
+  return mockRecord
+}
 
 const buildErrorResponse = (
   error: unknown,
@@ -130,19 +190,26 @@ export const POST: APIRoute = async ({ request, cookies, clientAddress }) => {
       })
     }
 
+    const normalizedEmail = normalizeNullableString(body.email ?? null)
+    const normalizedPurposes = sanitizePurposes(body.purposes)
+    const normalizedSource = sanitizeSource(body.source)
+    const normalizedUserAgent = normalizeUserAgent(body.userAgent)
+    const normalizedIpAddress = normalizeNullableString(body.ipAddress ?? null)
+    const normalizedConsentText = normalizeNullableString(body.consentText ?? null)
+
     let record: ConsentResponse['record']
     try {
       const { data, error } = await supabaseAdmin
         .from('consent_records')
         .insert({
           data_subject_id: body.DataSubjectId,
-          email: body.email?.toLowerCase().trim(),
-          purposes: body.purposes,
-          source: body.source,
-          user_agent: body.userAgent,
-          ip_address: body.ipAddress,
+          email: normalizedEmail,
+          purposes: normalizedPurposes,
+          source: normalizedSource,
+          user_agent: normalizedUserAgent,
+          ip_address: normalizedIpAddress,
           privacy_policy_version: getPrivacyPolicyVersion(),
-          consent_text: body.consentText,
+          consent_text: normalizedConsentText,
           verified: body.verified ?? false,
         })
         .select()
@@ -232,19 +299,7 @@ export const GET: APIRoute = async ({ clientAddress, url, request, cookies }) =>
       })
     }
 
-    const records = data.map(record => ({
-      id: record.id,
-      DataSubjectId: record.data_subject_id,
-      email: record.email,
-      purposes: record.purposes,
-      timestamp: record.timestamp,
-      source: record.source,
-      userAgent: record.user_agent,
-      ipAddress: record.ip_address,
-      privacyPolicyVersion: record.privacy_policy_version,
-      consentText: record.consent_text,
-      verified: record.verified
-    }))
+    const records = data.map(record => mapConsentRecord(record as ConsentRecordRow))
 
     return jsonResponse(
       {

src/pages/api/newsletter/_email.ts

@@ -23,6 +23,10 @@ function getMockAuthorizationHeader(): string {
   }
 }
 
+function resolveResendMockBaseUrl(force?: boolean) {
+  return force === undefined ? getResendMockBaseUrl() : getResendMockBaseUrl({ force })
+}
+
 /**
  * Generate the HTML content for the confirmation email
  */
@@ -208,7 +212,7 @@ export async function sendConfirmationEmail(
   firstName?: string,
   options?: SendConfirmationEmailOptions
 ): Promise<void> {
-  const resendMockBaseUrl = getResendMockBaseUrl({ force: options?.forceMockResend })
+  const resendMockBaseUrl = resolveResendMockBaseUrl(options?.forceMockResend)
   const siteUrl = getSiteUrl()
   const confirmUrl = `${siteUrl}/newsletter/confirm/${token}`
   const expiresIn = '24 hours'
@@ -306,7 +310,7 @@ export async function sendWelcomeEmail(
   firstName?: string,
   options?: SendWelcomeEmailOptions
 ): Promise<void> {
-  const resendMockBaseUrl = getResendMockBaseUrl({ force: options?.forceMockResend })
+  const resendMockBaseUrl = resolveResendMockBaseUrl(options?.forceMockResend)
 
   if (!resendMockBaseUrl && (isDev() || isTest())) {
     console.log('[DEV/TEST MODE] Newsletter welcome email would be sent:', { email })

test/e2e/specs/08-api/supabase.spec.ts

@@ -39,9 +39,7 @@ const TEST_USER_AGENT = 'playwright/supabase'
 const createdRecordIds: string[] = []
 
 const skipUnlessChromium = (browserName: string) => {
-  if (browserName !== 'chromium') {
-    test.skip('Supabase API tests only run once per suite')
-  }
+  test.skip(browserName !== 'chromium', 'Supabase API tests only run once per suite')
 }
 
 const buildConsentRecordPayload = () => ({