Fix CodeQL error on last push

Author: webstackdev

src/pages/api/social-card/__tests__/index.spec.ts

@@ -1,11 +1,10 @@
 import { beforeEach, describe, expect, it, vi } from 'vitest'
 import { GET } from '@pages/api/social-card'
 
-const avatarFetchMock = vi.hoisted(() => vi.fn())
-
 vi.mock('@assets/images/avatars/kevin-brown.webp', () => ({
   default: {
     src: '/_astro/kevin-brown.test.webp',
+    fsPath: '/virtual/assets/kevin-brown.webp',
   },
 }))
 
@@ -41,8 +40,6 @@ vi.mock('astro-og-canvas', () => ({
   generateOpenGraphImage: generateOpenGraphImageMock,
 }))
 
-vi.stubGlobal('fetch', avatarFetchMock)
-
 const buildRequest = (url: string) =>
   GET({
     request: new Request(url),
@@ -79,11 +76,6 @@ describe('Social Card API - GET /api/social-card', () => {
   beforeEach(() => {
     generateOpenGraphImageMock.mockReset()
     generateOpenGraphImageMock.mockResolvedValue(Buffer.from('mock-image'))
-    avatarFetchMock.mockReset()
-    avatarFetchMock.mockResolvedValue({
-      ok: true,
-      arrayBuffer: async () => Uint8Array.from([1, 2, 3]).buffer,
-    })
     seedCollections()
   })
 
@@ -141,7 +133,7 @@ describe('Social Card API - GET /api/social-card', () => {
     expect(generateOpenGraphImageMock).toHaveBeenCalledWith(
       expect.objectContaining({
         logo: expect.objectContaining({
-          path: expect.stringMatching(/kevin-brown\.webp$/u),
+          path: '/virtual/assets/kevin-brown.webp',
         }),
       })
     )

src/pages/api/social-card/index.ts

@@ -1,6 +1,3 @@
-import { mkdir, readFile, writeFile } from 'node:fs/promises'
-import { tmpdir } from 'node:os'
-import { join } from 'node:path'
 import type { APIRoute } from 'astro'
 import { getCollection } from 'astro:content'
 import { generateOpenGraphImage } from 'astro-og-canvas'
@@ -14,8 +11,10 @@ const ROUTE = '/api/social-card'
 const DEFAULT_TITLE = 'Platform Engineering by Kevin Brown'
 const DEFAULT_DESCRIPTION =
   'Platform engineer helping teams harden delivery, modernize cloud platforms, and improve developer experience.'
-const AVATAR_CACHE_DIR = join(tmpdir(), 'webstackbuilders-social-card')
-const AVATAR_CACHE_PATH = join(AVATAR_CACHE_DIR, 'kevin-brown.webp')
+
+type ImageMetadataWithFsPath = typeof kevinBrownAvatar & {
+  fsPath?: string
+}
 
 type CollectionKey = 'articles' | 'caseStudies' | 'services' | 'downloads'
 type PaletteKey = 'articles' | 'case-studies' | 'services' | 'downloads' | 'default'
@@ -61,24 +60,14 @@ const gradientPalette: Record<PaletteKey, [number, number, number][]> = {
   ],
 }
 
-const getAvatarUrl = (requestUrl: URL): URL => new URL(kevinBrownAvatar.src, requestUrl)
-
-const ensureAvatarFile = async (requestUrl: URL): Promise<string> => {
-  try {
-    await readFile(AVATAR_CACHE_PATH)
-    return AVATAR_CACHE_PATH
-  } catch {
-    const response = await fetch(getAvatarUrl(requestUrl))
+const getAvatarFilePath = (): string => {
+  const avatarFilePath = (kevinBrownAvatar as ImageMetadataWithFsPath).fsPath
 
-    if (!response.ok) {
-      throw new Error(`Unable to load avatar image: ${response.status} ${response.statusText}`)
-    }
-
-    const avatarBuffer = Buffer.from(await response.arrayBuffer())
-    await mkdir(AVATAR_CACHE_DIR, { recursive: true })
-    await writeFile(AVATAR_CACHE_PATH, avatarBuffer)
-    return AVATAR_CACHE_PATH
+  if (!avatarFilePath) {
+    throw new Error('Kevin Brown avatar asset is missing a local file path')
   }
+
+  return avatarFilePath
 }
 
 /** Normalize slug parameters to a consistent format */
@@ -144,7 +133,7 @@ export const GET: APIRoute = async ({ request, clientAddress, cookies }) => {
     const slug = normalizeSlug(url.searchParams.get('slug'))
     const titleOverride = url.searchParams.get('title')
     const descriptionOverride = url.searchParams.get('description')
-    const avatarPath = await ensureAvatarFile(url)
+    const avatarPath = getAvatarFilePath()
 
     const contentIndex = await buildContentIndex()
     const matchedEntry = contentIndex[slug]