fix: Remote images: Prevent internal caching from interfering with Astro's cache #14954
+6
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 16b475d The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
CodSpeed Performance ReportMerging #14954 will not alter performanceComparing Summary
Footnotes |
Member
florian-lefebvre
left a comment
florian-lefebvre
left a comment
There was a problem hiding this comment.
Can you add a test case for this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14942
Changes
Sets
cache: "no-cache"for the Request object when revalidating remote images. Internal caching mechanisms may change an expected HTTP 304 response to HTTP 200 in an opaque way which causes Astro to reprocess remote images even if it has the latest ones in its cache.Testing
Manual testing with my personal website. Before vs after:
Build time is way shorter since images are now used from cache.
Docs
No need to update docs since this simply fixes unexpected behavior.