Fix a crash when double-tap the Skip button in the site creation flow #25057
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Contributor
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 30129 | |
| Version | PR #25057 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 8722d52 | |
| Installation URL | 21o9kr1bm55d0 |
Contributor
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 30129 | |
| Version | PR #25057 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 8722d52 | |
| Installation URL | 28040cqndn7v8 |
kean
reviewed
Dec 12, 2025
| fetchSiteDesigns() | ||
|
|
||
| // Disable the button temporarily during the transition animation. | ||
| navigationItem.rightBarButtonItem?.isEnabled = false |
Contributor
There was a problem hiding this comment.
Are there different ways to address it? It seems like a fix for a symptom rather than the root cause.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The crash happens because the first screen and the second screen both have a
rightBarButtonItem, whose action calls the same function (eventually). When double-tapping the "Skip" button, the first tap is handled by the first screenSiteIntentViewController, and the second tap is handled by the second screenSiteDesignContentCollectionViewController. Both bar button items trigger the same code:WizardNavigation.nextStep. The internal step ofWizardNavigationis not updated because the view controllers are still transitioning.This PR fixes the issue by disabling the second Skip button during the push animation.
Testing instructions
Enter the WordPress.com site creation flow, and double-tap the Skip button.