Skip to content

Separate Directory and DirectoryBackground#70

Open
archit9169 wants to merge 5 commits into0install:masterfrom
archit9169:patch-1
Open

Separate Directory and DirectoryBackground#70
archit9169 wants to merge 5 commits into0install:masterfrom
archit9169:patch-1

Conversation

@archit9169
Copy link
Copy Markdown

No description provided.

Add background option for separate directory and background.
Change target name from directorybackground to only background to keep naming consistent across the source code.
@bastianeicher
Copy link
Copy Markdown
Member

This would probably work. The unit tests only failed because of an unrelated issue with desktop integration on Linux, which I've fixed in he meantime.

However, I'm not really sure if this feature will be useful. While some applications may only add Directory and not Directory\Background context menu entries, I believe this is usually just an oversight or a holdover from older Windows versions that did not support Directory\Background yet.

Is there any harm to always adding the entry to both? This would keep the feed format simpler, also avoiding the need to update to update the "capabilities" caspecification and existing feeds on apps.0install.net

@archit9169
Copy link
Copy Markdown
Author

archit9169 commented Aug 1, 2020

I was thinking what if a program does not needs to add that context menu entry. Because in some cases those entries are not very useful, and personally i like to keep thing organised, even context menu entries. But on the other hand i am not sure if other users really care about that and it might be only me. Is there any other way that users like me can get an option to choose either one or both without changing the current implementation?

What about an extra tag in capabilities named "Exclude" or something that can be false by default and when enabled or made true, it excludes the background from directory?

Eg:

if(ExcludeBackground) {
ContextMenuTarget.Directories => new[] {RegKeyClassesDirectories},
} else {
ContextMenuTarget.Directories => new[] {RegKeyClassesDirectories, RegKeyClassesDirectories + @"\Background"},
}

@bastianeicher bastianeicher force-pushed the master branch 7 times, most recently from edd9c81 to 8570d84 Compare August 8, 2020 11:37
@bastianeicher bastianeicher force-pushed the master branch 2 times, most recently from 21b37a5 to 555e6f3 Compare August 16, 2020 11:51
@bastianeicher bastianeicher force-pushed the master branch 2 times, most recently from fdbd739 to 22e3618 Compare November 10, 2020 09:54
@bastianeicher bastianeicher force-pushed the master branch 6 times, most recently from 4312137 to 8792643 Compare December 4, 2020 21:11
@bastianeicher bastianeicher force-pushed the master branch 4 times, most recently from d0d4634 to 17c4079 Compare December 22, 2020 14:15
@bastianeicher bastianeicher force-pushed the master branch 4 times, most recently from 569035b to 9ba6d1f Compare March 22, 2021 10:08
@bastianeicher bastianeicher force-pushed the master branch 2 times, most recently from dc6252e to 1eb5993 Compare April 11, 2021 13:44
@bastianeicher bastianeicher force-pushed the master branch 3 times, most recently from 0340ab2 to 7f8587f Compare July 16, 2021 22:09
@bastianeicher bastianeicher force-pushed the master branch 5 times, most recently from 36e2552 to 564e3aa Compare August 7, 2021 10:50
@bastianeicher bastianeicher force-pushed the master branch 6 times, most recently from 4316221 to 22f3f44 Compare August 29, 2021 19:30
@bastianeicher bastianeicher force-pushed the master branch 9 times, most recently from 8449436 to 820a29c Compare September 15, 2021 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants