Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I couldn't get the outdated version of webpack-dev-server running locally. This replaces it with vite, which is a much more modern tool built on top of esbuild. I also couldn't get the old eslint running. I didn't see anywhere it was being used, so I just updated to the latest version using the default config.
A note on commands:
npm startstill runs the demo in development modenpm run buildstill builds the library (sonpm publishjust works)npm run build:demowill build the demo for publishingnpm run lintwill run eslintNote
I know this library has been stagnant for a while, so I'm not sure if my recent PRs will be merged or not. In the meantime, I'll be maintaining a fork with all my improvements at chordbook/vexchords.