Fix Private Eye lock icon underline#288
Open
arpitjain099 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #223.
The lock icon from Private Eye is added with a pseudo-element on the anchor. Even with text-decoration set to none, the icon can still pick up underline styling because it stays in the same inline text flow.
This updates the injected style so the icon renders as an inline-block and stays top-aligned. That keeps the same lock glyph and size while preventing the icon underline.
I verified the script still parses and runs by executing assets/js/vendor/private_eye.js in a Node test harness, checking that links are tagged as private-link and the injected style includes display: inline-block plus vertical-align: top.