fix: improve community restore loading state - #13475
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Enterprise license-required page to present a dedicated “community restore in progress” overlay (instead of Element Plus’ fullscreen v-loading) and adjusts the restore-status loading flow to start earlier during mount.
Changes:
- Replaced the previous fullscreen
v-loadingrestore state with a custom, animated restore overlay and transition. - Introduced a local
restoringref initialized fromisOnRestartand updated the mounting flow to prioritize restore detection/polling. - Added new scoped SCSS for the restore overlay and removed now-unused loading-mask theme variable styling.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Suppressed comments (1)
frontend/src/views/setting/license-required/index.vue:151
restoringis initialized fromisOnRestart.valueand then manually kept in sync in multiple places (e.g.,isOnRestart.value = restoring.value). This introduces two sources of truth and risks state divergence if either is updated independently. Consider makingrestoringa writable computed that directly proxiesisOnRestartso the store remains the single source of truth.
const restoring = ref(isOnRestart.value);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.