Skip to content

fix: improve community restore loading state - #13475

Merged
ssongliu merged 2 commits into
dev-v2from
fix/community-restore-loading-mask
Aug 5, 2026
Merged

fix: improve community restore loading state#13475
ssongliu merged 2 commits into
dev-v2from
fix/community-restore-loading-mask

Conversation

@ssongliu

@ssongliu ssongliu commented Aug 5, 2026

Copy link
Copy Markdown
Member

No description provided.

Copilot AI lite review requested due to automatic review settings August 5, 2026 03:55

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Enterprise license-required page to present a dedicated “community restore in progress” overlay (instead of Element Plus’ fullscreen v-loading) and adjusts the restore-status loading flow to start earlier during mount.

Changes:

  • Replaced the previous fullscreen v-loading restore state with a custom, animated restore overlay and transition.
  • Introduced a local restoring ref initialized from isOnRestart and updated the mounting flow to prioritize restore detection/polling.
  • Added new scoped SCSS for the restore overlay and removed now-unused loading-mask theme variable styling.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread frontend/src/views/setting/license-required/index.vue
Copilot AI review requested due to automatic review settings August 5, 2026 05:40

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Suppressed comments (1)

frontend/src/views/setting/license-required/index.vue:151

  • restoring is initialized from isOnRestart.value and then manually kept in sync in multiple places (e.g., isOnRestart.value = restoring.value). This introduces two sources of truth and risks state divergence if either is updated independently. Consider making restoring a writable computed that directly proxies isOnRestart so the store remains the single source of truth.
const restoring = ref(isOnRestart.value);

@ssongliu
ssongliu merged commit 9204a28 into dev-v2 Aug 5, 2026
4 checks passed
@ssongliu
ssongliu deleted the fix/community-restore-loading-mask branch August 5, 2026 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants