Add semantic highlighting for NStr and StrTemplate functions #3697
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
Implement NStrAndStrTemplateSemanticTokensSupplier to highlight: - Language keys (ru=, en=) in NStr/НСтр function calls - Placeholders (%1, %2, %(1)) in StrTemplate/СтрШаблон function calls Co-authored-by: nixel2007 <[email protected]>
Copilot
AI
changed the title
[WIP] Resolve coloring issue for Nstr and StrShablon
Add semantic highlighting for NStr and StrTemplate functions
Dec 21, 2025
nixel2007
reviewed
Dec 21, 2025
| */ | ||
| @Component | ||
| @RequiredArgsConstructor | ||
| public class NStrAndStrTemplateSemanticTokensSupplier implements SemanticTokensSupplier { |
Member
There was a problem hiding this comment.
@copilot используй MultilingualStringAnalyser. Расширь его при необходимости
Contributor
Author
There was a problem hiding this comment.
Refactored to use MultilingualStringAnalyser. Extended it with:
isNStrCall()andisStrTemplateCall()static methodsfindLanguageKeyPositions()andfindPlaceholderPositions()static methodsMatchPositionrecord for position infoSTR_TEMPLATE_PLACEHOLDER_PATTERN(same pattern as inIncorrectUseOfStrTemplateDiagnostic)
Commit: 5c618ee
…ighting - Extended MultilingualStringAnalyser with public patterns and utility methods: - isNStrCall() and isStrTemplateCall() static methods - findLanguageKeyPositions() and findPlaceholderPositions() static methods - MatchPosition record for position information - STR_TEMPLATE_PLACEHOLDER_PATTERN for placeholder detection - Updated NStrAndStrTemplateSemanticTokensSupplier to use MultilingualStringAnalyser - Removed duplicate patterns from semantic tokens supplier Co-authored-by: nixel2007 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NStrAndStrTemplateSemanticTokensSupplierto add semantic highlighting for NStr/НСтр and StrTemplate/СтрШаблонMultilingualStringAnalyserinstead of duplicating patternsSummary
This PR implements semantic syntax highlighting for
NStr/НСтрandStrTemplate/СтрШаблонfunction calls:NStr/НСтр Highlighting
Language keys in multilingual strings are highlighted as
Property:StrTemplate/СтрШаблон Highlighting
Placeholders in template strings are highlighted as
Parameter:Implementation
Extended
MultilingualStringAnalyserwith:isNStrCall(),isStrTemplateCall(),findLanguageKeyPositions(),findPlaceholderPositions()MatchPositionrecord for returning position informationThe implementation follows the existing patterns in the codebase and reuses the
MultilingualStringAnalyseras requested.Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.