fix(server): treat expired JWT as no-auth instead of 401 - #2
Open
22f wants to merge 1 commit into
Open
Conversation
When an HTTP client's Bearer JWT expires, the auth middleware rejected ALL requests with 401 — including signin and invalidate, which are the operations needed to recover. This created a deadlock where the client could not obtain a fresh token without creating a brand new connection. The fix treats an expired Bearer token as equivalent to no token, falling back to an unauthenticated session. This lets recovery endpoints (signin, invalidate) proceed normally while other endpoints still enforce permissions via their handlers. WebSocket connections were unaffected as they handle auth per-RPC-method. Uses the existing `is_expired_token_error()` helper from core::iam. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Open
3 tasks
Owner
Author
|
@claude review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
signin()orinvalidate()because the middleware blocks the request before reaching the endpoint handleris_expired_token_error()helper fromcore::iamChanged files
surrealdb/server/src/ntw/auth.rs— catchExpiredTokenincheck_auth(), fall back to unauthenticated sessiontests/http_integration.rs— new testexpired_jwt_does_not_block_signinTest plan
expired_jwt_does_not_block_signinpasses🤖 Generated with Claude Code