Drop the pane-grid tables and the legacy membership columns the node tree replaced (0256)

apps/web/src/app/api/agent-workspaces/[workspaceId]/conversations/[conversationId]/claim/__tests__/route.test.ts

@@ -213,23 +213,3 @@ describe('POST /api/agent-workspaces/[workspaceId]/conversations/[conversationId
     expect(mockCheckSessionAccess).not.toHaveBeenCalled();
   });
 });
-
-describe('the workspace is waiting for the backfill', () => {
-  /**
-   * 503, not 404 and not 200. The conversation exists and is the caller's; the
-   * SERVER has not migrated this workspace yet, and it becomes ready when an
-   * operator runs the backfill — which is what 503 says and what nothing else on
-   * this route does.
-   *
-   * The status is asserted rather than assumed because this route has no
-   * exhaustiveness check: an adversarial review found that deleting the 503
-   * block lets the request fall through to `200 OK`, reporting success for a
-   * write the server refused.
-   */
-  it('answers 503 and names the reason', async () => {
-    mockClaimConversationInSession.mockResolvedValue('awaiting_backfill');
-    const response = await post();
-    expect(response.status).toBe(503);
-    expect(await response.json()).toMatchObject({ code: 'awaiting_backfill' });
-  });
-});

apps/web/src/app/api/agent-workspaces/[workspaceId]/conversations/[conversationId]/claim/route.ts

@@ -100,17 +100,6 @@ export async function POST(request: Request, context: RouteContext) {
     );
   }
 
-  if (outcome === 'awaiting_backfill') {
-    // 503, matching `POST /nodes`. The conversation exists and is the caller's;
-    // the SERVER has not migrated this workspace yet and no action by the
-    // caller changes that. A 404 here would be a lie about a thread the user
-    // can see, and would send them looking for it.
-    return NextResponse.json(
-      { error: 'This session is not ready yet. Its data is still being migrated.', code: 'awaiting_backfill' },
-      { status: 503 },
-    );
-  }
-
   if (outcome === 'session_full') {
     return sessionConversationLimitExceeded(request, auth.userId, workspaceId, ROUTE);
   }
@@ -125,9 +114,22 @@ export async function POST(request: Request, context: RouteContext) {
     });
   }
 
-  // `alreadyInSession` (outcome === 'already_in_session'): this call did NOT
-  // transition anything — same reasoning as the reopen route's
-  // `alreadyOpen`, so a caller superseded mid-flight knows whether it's
-  // safe to roll the listing back out.
-  return NextResponse.json({ ok: true, alreadyInSession: outcome === 'already_in_session' });
+  // EXHAUSTIVENESS BACKSTOP. Everything below this line is a SUCCESS response,
+  // so a refusal that reaches it is answered `200 {ok: true}` — the server
+  // reporting success for a write it declined. This route dispatches with an
+  // `if`-chain, which TypeScript cannot check for completeness on its own, so
+  // the narrowing is written down instead: adding a refusal to
+  // `ClaimConversationOutcome` without an arm above is a COMPILE error here.
+  //
+  // This used to be pinned by a test asserting the 503 arm's status ("deleting
+  // the 503 block lets the request fall through to 200 OK"). That arm and its
+  // test went with the `awaiting_backfill` refusal at migration 0256, taking the
+  // guarantee with them for every code that remains — hence stating it in the
+  // types, where it cannot be deleted by removing a test.
+  const settled: 'claimed' | 'already_in_session' = outcome;
+
+  // `alreadyInSession`: this call did NOT transition anything — same reasoning
+  // as the reopen route's `alreadyOpen`, so a caller superseded mid-flight
+  // knows whether it's safe to roll the listing back out.
+  return NextResponse.json({ ok: true, alreadyInSession: settled === 'already_in_session' });
 }

apps/web/src/app/api/agent-workspaces/[workspaceId]/conversations/[conversationId]/reopen/__tests__/route.test.ts

@@ -146,23 +146,3 @@ describe('POST /api/agent-workspaces/[workspaceId]/conversations/[conversationId
     expect(mockCheckSessionAccess).not.toHaveBeenCalled();
   });
 });
-
-describe('the workspace is waiting for the backfill', () => {
-  /**
-   * 503, not 404 and not 200. The conversation exists and is the caller's; the
-   * SERVER has not migrated this workspace yet, and it becomes ready when an
-   * operator runs the backfill — which is what 503 says and what nothing else on
-   * this route does.
-   *
-   * The status is asserted rather than assumed because this route has no
-   * exhaustiveness check: an adversarial review found that deleting the 503
-   * block lets the request fall through to `200 OK`, reporting success for a
-   * write the server refused.
-   */
-  it('answers 503 and names the reason', async () => {
-    mockReopenConversationInSession.mockResolvedValue('awaiting_backfill');
-    const response = await post();
-    expect(response.status).toBe(503);
-    expect(await response.json()).toMatchObject({ code: 'awaiting_backfill' });
-  });
-});

apps/web/src/app/api/agent-workspaces/[workspaceId]/conversations/[conversationId]/reopen/route.ts

@@ -60,17 +60,6 @@ export async function POST(request: Request, context: RouteContext) {
     return NextResponse.json({ error: 'Conversation not found' }, { status: 404 });
   }
 
-  if (outcome === 'awaiting_backfill') {
-    // 503, matching `POST /nodes`. The conversation exists and is the caller's;
-    // the SERVER has not migrated this workspace yet and no action by the
-    // caller changes that. A 404 here would be a lie about a thread the user
-    // can see, and would send them looking for it.
-    return NextResponse.json(
-      { error: 'This session is not ready yet. Its data is still being migrated.', code: 'awaiting_backfill' },
-      { status: 503 },
-    );
-  }
-
   if (outcome === 'session_full') {
     // 409, not 404: the thread exists and is the caller's, and the workspace is
     // simply full. This is the one refusal on this path a user can resolve —
@@ -92,6 +81,13 @@ export async function POST(request: Request, context: RouteContext) {
     });
   }
 
+  // EXHAUSTIVENESS BACKSTOP — see the twin in `claim/route.ts`. Everything
+  // below is a SUCCESS response, so a refusal reaching it is answered
+  // `200 {ok: true}`. An `if`-chain cannot be checked for completeness, so the
+  // narrowing is written down: adding a refusal to `ReopenConversationOutcome`
+  // without an arm above is a COMPILE error here rather than a silent success.
+  const settled: 'reopened' | 'already_open' = outcome;
+
   // `alreadyOpen` (outcome === 'already_open'): this call did NOT transition
   // the listing — it was already open (e.g. a different pane, tab, or an
   // agent switch that left it open but unshown). The caller needs this to
@@ -100,5 +96,5 @@ export async function POST(request: Request, context: RouteContext) {
   // listing the request never actually opened, possibly still in use
   // elsewhere (review finding — chatgpt-codex-connector on PR #2299,
   // round 15).
-  return NextResponse.json({ ok: true, alreadyOpen: outcome === 'already_open' });
+  return NextResponse.json({ ok: true, alreadyOpen: settled === 'already_open' });
 }

apps/web/src/app/api/agent-workspaces/[workspaceId]/nodes/__tests__/route.test.ts

@@ -170,23 +170,6 @@ describe('the answers', () => {
     expect((await post({ baseRev: 4, put: [], drop: [] })).status).toBe(400);
   });
 
-  it('503 while the backfill has not reached this workspace — the SERVER is unready, not the write', async () => {
-    // Not 400: the write was valid and nothing the caller changes would help.
-    // Not 409 either, which invites a rebase-and-retry against a tree that must
-    // not be written at all — so this carries no snapshot. It stops being true
-    // when the backfill runs, which is exactly what 503 says.
-    mockApply.mockResolvedValue({
-      status: 'refused',
-      code: 'awaiting_backfill',
-      detail: 'this workspace still holds membership that only the previous model records',
-    });
-    const response = await post({ baseRev: 4, put: [], drop: [] });
-    expect(response.status).toBe(503);
-    const body = await response.json();
-    expect(body).toMatchObject({ code: 'awaiting_backfill' });
-    expect(body).not.toHaveProperty('nodes');
-  });
-
   it('403 for a binding the caller may not make, and says nothing about which', async () => {
     mockApply.mockResolvedValue({
       status: 'refused',

apps/web/src/app/api/agent-workspaces/[workspaceId]/nodes/route.ts

@@ -121,19 +121,6 @@ export async function POST(request: Request, context: RouteContext) {
     if (result.code === 'forbidden_target') {
       return NextResponse.json({ error: result.detail }, { status: 403 });
     }
-    // 503, because nothing is wrong with the write and nothing the caller can
-    // change would help: this database still holds membership only the previous
-    // model records, and writing would strand it permanently (see
-    // `awaitsBackfill`). It is the SERVER that is not ready, and
-    // it stops being unready when the backfill runs — which is what 503 means
-    // and what neither 400 nor 409 does. A client must not treat it as a
-    // rebase-and-retry, so it carries no snapshot.
-    if (result.code === 'awaiting_backfill') {
-      return NextResponse.json(
-        { error: 'This workspace is not ready yet. Its data is still being migrated.', code: result.code },
-        { status: 503 },
-      );
-    }
     return NextResponse.json(
       { error: 'That write would not leave a valid workspace', code: result.code, detail: result.detail },
       { status: 400 },

apps/web/src/app/api/agent-workspaces/route.ts

@@ -199,9 +199,8 @@ export async function GET(request: Request) {
  * session's first thing, instead of minting a brand-new one —
  * `claimConversationInSession` (`claim-conversation-in-workspace.ts`), which
  * ADMITS the thread — one node in `agent_workspace_nodes`, which is what
- * membership is. It used to write `conversations.workspaceId`; nothing writes
- * that column now, and it survives only until the follow-up migration drops
- * it. `driveId`/`agentPageId`
+ * membership is. It used to write `conversations.workspaceId`, a column
+ * migration 0256 dropped. `driveId`/`agentPageId`
  * are derived from the claimed row itself (a `type: 'page'` row's own agent;
  * a `type: 'global'` row takes the caller's `driveId`, same three-shape
  * ambiguity as the ordinary mint path below) — a caller-supplied

apps/web/src/app/api/ai/chat/__tests__/conversation-page-binding.test.ts

@@ -280,9 +280,7 @@ const conversationRow = (overrides: Record<string, unknown>) => ({
   title: null,
   type: 'page',
   contextId: THIS_PAGE,
-  workspaceId: null,
   agentPageId: null,
-  closedInWorkspaceAt: null,
   rev: 0,
   lastMessageAt: null,
   createdAt: new Date(),

apps/web/src/app/api/ai/global/[id]/__tests__/route.test.ts

@@ -87,8 +87,6 @@ const mockConversation = (overrides: Partial<{
   createdAt: Date;
   updatedAt: Date;
   isActive: boolean;
-  workspaceId: string | null;
-  closedInWorkspaceAt: Date | null;
 }> = {}) => ({
   id: overrides.id ?? mockConversationId,
   userId: overrides.userId ?? mockUserId,
@@ -99,8 +97,6 @@ const mockConversation = (overrides: Partial<{
   createdAt: overrides.createdAt ?? new Date(),
   updatedAt: overrides.updatedAt ?? new Date(),
   isActive: overrides.isActive ?? true,
-  workspaceId: overrides.workspaceId ?? null,
-  closedInWorkspaceAt: overrides.closedInWorkspaceAt ?? null,
 });
 
 const createContext = (id: string) => ({

apps/web/src/app/api/ai/global/[id]/messages/[messageId]/__tests__/route.test.ts

@@ -108,8 +108,6 @@ const mockConversation = (overrides: Partial<{
   lastMessageAt: new Date(),
   createdAt: new Date(),
   updatedAt: new Date(),
-  workspaceId: null,
-  closedInWorkspaceAt: null,
 });
 
 const mockMessage = (overrides: Partial<{

apps/web/src/app/api/ai/global/[id]/messages/__tests__/stream-socket-events.test.ts

@@ -768,7 +768,7 @@ describe('POST /api/ai/global/[id]/messages — lifecycle handoff', () => {
   const newConv = {
     id: 'conv-1', userId: 'user-1', title: null, type: 'global',
     contextId: null, isActive: true, isShared: false,
-  workspaceId: null, closedInWorkspaceAt: null, agentPageId: null, rev: 0, planPageId: null,
+  agentPageId: null, rev: 0, planPageId: null,
     createdAt: new Date('2024-01-01'), updatedAt: new Date('2024-01-01'), lastMessageAt: null,
   };
 

apps/web/src/app/api/ai/global/[id]/usage/__tests__/route.test.ts

@@ -88,8 +88,6 @@ const mockConversation = (overrides: Partial<{
   lastMessageAt: new Date(),
   createdAt: new Date(),
   updatedAt: new Date(),
-  workspaceId: null,
-  closedInWorkspaceAt: null,
 });
 
 const mockUsageLog = (overrides: Partial<{

apps/web/src/app/api/ai/global/__tests__/route.test.ts

@@ -92,8 +92,6 @@ const mockConversation = (overrides: Partial<{
   createdAt: overrides.createdAt ?? new Date(),
   updatedAt: overrides.updatedAt ?? new Date(),
   isActive: overrides.isActive ?? true,
-  workspaceId: null,
-  closedInWorkspaceAt: null,
 });
 
 const createGetRequest = () =>

apps/web/src/app/api/ai/page-agents/[agentId]/conversations/[conversationId]/__tests__/route.test.ts

@@ -116,7 +116,7 @@ const mockAgent = () => ({
 });
 
 const mockConversationRow = (
-  overrides: Partial<{ userId: string; isShared: boolean; workspaceId: string | null; closedInWorkspaceAt: Date | null; isActive: boolean }> = {},
+  overrides: Partial<{ userId: string; isShared: boolean; isActive: boolean }> = {},
 ) => ({
   id: mockConversationId,
   userId: mockUserId,
@@ -125,8 +125,7 @@ const mockConversationRow = (
   title: null,
   isActive: true,
   isShared: false,
-  workspaceId: null,
-  closedInWorkspaceAt: null, agentPageId: null, rev: 0,
+  agentPageId: null, rev: 0,
   planPageId: null,
   lastMessageAt: null,
   createdAt: new Date('2025-01-01'),

apps/web/src/app/api/ai/page-agents/[agentId]/conversations/[conversationId]/messages/__tests__/route.test.ts

@@ -141,8 +141,7 @@ const mockConversationRow = (overrides: Partial<{ userId: string; isShared: bool
   title: null,
   isActive: true,
   isShared: false,
-  workspaceId: null,
-  closedInWorkspaceAt: null, agentPageId: null, rev: 0,
+  agentPageId: null, rev: 0,
   planPageId: null,
   lastMessageAt: null,
   createdAt: new Date('2025-01-01'),

apps/web/src/app/api/v1/chat/completions/__tests__/route-backfill.test.ts

@@ -263,11 +263,6 @@ describe('POST /api/v1/chat/completions — back-fill tool results', () => {
       planPageId: null,
       type: 'page',
       lastMessageAt: null,
-      // Dead membership columns, present until the follow-up migration drops
-      // them. Nothing writes them; a node in `agent_workspace_nodes` is the
-      // membership now.
-      workspaceId: null,
-      closedInWorkspaceAt: null,
     });
 
     const fullHistory = [
@@ -337,11 +332,6 @@ describe('POST /api/v1/chat/completions — back-fill tool results', () => {
       planPageId: null,
       type: 'page',
       lastMessageAt: null,
-      // Dead membership columns, present until the follow-up migration drops
-      // them. Nothing writes them; a node in `agent_workspace_nodes` is the
-      // membership now.
-      workspaceId: null,
-      closedInWorkspaceAt: null,
     });
 
     // OpenAI-format messages with no `id` fields, just like pagespace-cli sends
@@ -388,11 +378,6 @@ describe('POST /api/v1/chat/completions — back-fill tool results', () => {
       planPageId: null,
       type: 'page',
       lastMessageAt: null,
-      // Dead membership columns, present until the follow-up migration drops
-      // them. Nothing writes them; a node in `agent_workspace_nodes` is the
-      // membership now.
-      workspaceId: null,
-      closedInWorkspaceAt: null,
     });
 
     const fullHistory = [