Fix Windows SDL2 + CMake 4 brokenness - #914
Merged
Merged
Conversation
2.28.3 is the minimum version to avoid the "Compatibility with CMake < 3.5 has been removed from CMake." error. Also bump SDL2_image for the same reason. Unfortunately there isn't a version of SDL2_net with the fix for the VC build.
While we're here...
Contributor
|
ohno but also omg non-zipped artifacts!!!!!! |
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Strikes again...
Tried to keep this to the minimum updating to fix things (and not break other things, which updating SDL2_image on macOS would do...)
(I was trying to test the upload-artifact action finally supporting not zipping a file, but got windows breakage instead...)