Skip to content

3d jan/fix function gradient outputname#457

Merged
vijaiaeroastro merged 4 commits into
premerge/2.5.0_into_masterfrom
3dJan/FixFunctionGradientOutputname
Feb 28, 2026
Merged

3d jan/fix function gradient outputname#457
vijaiaeroastro merged 4 commits into
premerge/2.5.0_into_masterfrom
3dJan/FixFunctionGradientOutputname

Conversation

@3dJan
Copy link
Copy Markdown
Contributor

@3dJan 3dJan commented Feb 27, 2026

  • FunctionGradientNode: Renaming the output normalizedgradient to vector to be complaint to the spec
  • Removing temporary instruction file

…tVector and update related bindings and documentation to reflect the change in output type from normalized gradient to vector
…tVector and update related bindings and documentation to reflect the change in output type
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 27, 2026

Codecov Report

❌ Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.66%. Comparing base (8658f65) to head (36e46da).
⚠️ Report is 1 commits behind head on premerge/2.5.0_into_master.

Files with missing lines Patch % Lines
Autogenerated/Source/lib3mf_interfacewrapper.cpp 77.77% 2 Missing ⚠️
Additional details and impacted files
@@                     Coverage Diff                     @@
##           premerge/2.5.0_into_master     #457   +/-   ##
===========================================================
  Coverage                       59.66%   59.66%           
===========================================================
  Files                              64       64           
  Lines                           24646    24646           
===========================================================
  Hits                            14705    14705           
  Misses                           9941     9941           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request renames the output port of the FunctionGradientNode from "normalizedgradient" to "vector" to comply with the 3MF specification. It also removes a temporary instruction file that is no longer needed.

Changes:

  • Renamed the GetOutputNormalizedGradient() method to GetOutputVector() across all API bindings
  • Updated the internal output port name from "normalizedgradient" to "vector" in the node type definitions
  • Removed the temporary documentation file docs/implicit_nodes_extension_plan.md

Reviewed changes

Copilot reviewed 31 out of 31 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
docs/implicit_nodes_extension_plan.md Removed temporary planning document (no longer needed)
Tests/CPP_Bindings/Source/ImplicitNodes.test.cpp Updated test code to use renamed method GetOutputVector()
Source/Model/Classes/NMR_ImplicitNodeTypes.cpp Changed output port name from "normalizedgradient" to "vector" in node definition
Source/API/lib3mf_functiongradientnode.cpp Updated implementation to look up "vector" port instead of "normalizedgradient"
Include/API/lib3mf_functiongradientnode.hpp Renamed method signature from GetOutputNormalizedGradient() to GetOutputVector()
AutomaticComponentToolkit/lib3mf.xml Updated ACT definition with new method name and improved description
Autogenerated/Source/lib3mf_interfacewrapper.cpp Regenerated wrapper with renamed method
Autogenerated/Source/lib3mf_interfaces.hpp Regenerated interface with renamed method
Autogenerated/Source/lib3mf_abi.hpp Regenerated ABI with renamed C function
Autogenerated/Bindings/WASM/lib3mf_bindings.cpp Regenerated WASM binding with renamed method
Autogenerated/Bindings/Python/Lib3MF.py Regenerated Python binding with renamed method
Autogenerated/Bindings/Pascal/Unit_Lib3MF.pas Regenerated Pascal binding with renamed method
Autogenerated/Bindings/NodeJS/lib3mf_nodewrapper.h Regenerated Node.js header with renamed method
Autogenerated/Bindings/NodeJS/lib3mf_nodewrapper.cc Regenerated Node.js implementation with renamed method
Autogenerated/Bindings/NodeJS/lib3mf_dynamic.h Regenerated Node.js dynamic header with renamed function pointer
Autogenerated/Bindings/NodeJS/lib3mf_dynamic.cc Regenerated Node.js dynamic implementation with renamed function
Autogenerated/Bindings/Java9/lib3mf/Lib3MFWrapper.java Regenerated Java 9 wrapper with renamed method
Autogenerated/Bindings/Java9/lib3mf/FunctionGradientNode.java Regenerated Java 9 class with renamed method
Autogenerated/Bindings/Java8/lib3mf/Lib3MFWrapper.java Regenerated Java 8 wrapper with renamed method
Autogenerated/Bindings/Java8/lib3mf/FunctionGradientNode.java Regenerated Java 8 class with renamed method
Autogenerated/Bindings/Go/lib3mf_dynamic.h Regenerated Go dynamic header with renamed function pointer
Autogenerated/Bindings/Go/lib3mf_dynamic.c Regenerated Go dynamic implementation with renamed function
Autogenerated/Bindings/Go/lib3mf.go Regenerated Go binding with renamed method
Autogenerated/Bindings/CppDynamic/lib3mf_dynamic.hpp Regenerated C++ dynamic header with renamed method
Autogenerated/Bindings/CppDynamic/lib3mf_dynamic.h Regenerated C++ dynamic C header with renamed function pointer
Autogenerated/Bindings/Cpp/lib3mf_implicit.hpp Regenerated C++ binding with renamed method
Autogenerated/Bindings/Cpp/lib3mf_abi.hpp Regenerated C++ ABI with renamed C function
Autogenerated/Bindings/CSharp/Lib3MF.cs Regenerated C# binding with renamed method
Autogenerated/Bindings/CDynamic/lib3mf_dynamic.h Regenerated C dynamic header with renamed function pointer
Autogenerated/Bindings/CDynamic/lib3mf_dynamic.cc Regenerated C dynamic implementation with renamed function
Autogenerated/Bindings/C/lib3mf.h Regenerated C header with renamed function

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Tests/CPP_Bindings/Source/ImplicitNodes.test.cpp Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Collaborator

@vijaiaeroastro vijaiaeroastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@vijaiaeroastro vijaiaeroastro merged commit 89cf743 into premerge/2.5.0_into_master Feb 28, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants