Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 5, 2025

PEP 517 isolated builds fail with FileNotFoundError: 'requirements-core.txt' because setup.py reads this file to populate install_requires, but it's not included in source distributions.

Changes

  • Added include requirements-core.txt to MANIFEST.in to ensure the file is available in sdist and during isolated builds

The file already existed in the repository but was missing from the manifest, causing builds in temporary isolated environments to fail when the build backend attempted to read it during setup.

Original prompt

Failure summary:
The GitHub Actions job 57207927600 failed during the PEP 517 build step with FileNotFoundError: 'requirements-core.txt' while invoking get_requires_for_build_wheel. The job run: https://github.com/4n4nd/prometheus-api-client-python/actions/runs/19950033672/job/57207927600 (ref: ba65a6d).

Root cause:
During isolated build (PEP 517), the build backend cannot find requirements-core.txt in the temporary build source, causing setup-time file read to fail even though the file exists in the repository at: https://github.com/4n4nd/prometheus-api-client-python/blob/ba65a6d34924b0a2938266d5a8bb639185fd222e/requirements-core.txt (blob: bbfd6bf2212e51a9a7bcc7d5633fc644c2374afa).

Requested change:
Add a MANIFEST.in at the repository root to ensure requirements-core.txt is included in source distributions and made available to isolated build environments.

Implementation details:

  • Create or update file MANIFEST.in at repository root with the following content:

include requirements-core.txt

  • Commit message: "Include requirements-core.txt in sdist via MANIFEST.in"
  • Create a new branch for the PR (e.g., add-manifest-include-requirements-core)
  • Open a pull request with a concise title (above) and description linking to the failing job and describing that this change prevents FileNotFoundError during PEP 517 builds.

Files changed:

  • MANIFEST.in (new file) with exact contents: "include requirements-core.txt\n"

Notes:

  • This change does not alter runtime behavior; it only ensures the file is available to build backends that operate in isolated temporary directories.
  • I did not modify setup.py to change how the file is read; adding MANIFEST.in addresses the immediate CI failure while keeping changes minimal as requested.

Please review and merge the PR. If you would also like me to update setup code to read requirements-core.txt relative to setup.py to make the project more robust, I can include that in this PR or a follow-up PR.

This pull request was created as a result of the following prompt from Copilot chat.

Failure summary:
The GitHub Actions job 57207927600 failed during the PEP 517 build step with FileNotFoundError: 'requirements-core.txt' while invoking get_requires_for_build_wheel. The job run: https://github.com/4n4nd/prometheus-api-client-python/actions/runs/19950033672/job/57207927600 (ref: ba65a6d).

Root cause:
During isolated build (PEP 517), the build backend cannot find requirements-core.txt in the temporary build source, causing setup-time file read to fail even though the file exists in the repository at: https://github.com/4n4nd/prometheus-api-client-python/blob/ba65a6d34924b0a2938266d5a8bb639185fd222e/requirements-core.txt (blob: bbfd6bf2212e51a9a7bcc7d5633fc644c2374afa).

Requested change:
Add a MANIFEST.in at the repository root to ensure requirements-core.txt is included in source distributions and made available to isolated build environments.

Implementation details:

  • Create or update file MANIFEST.in at repository root with the following content:

include requirements-core.txt

  • Commit message: "Include requirements-core.txt in sdist via MANIFEST.in"
  • Create a new branch for the PR (e.g., add-manifest-include-requirements-core)
  • Open a pull request with a concise title (above) and description linking to the failing job and describing that this change prevents FileNotFoundError during PEP 517 builds.

Files changed:

  • MANIFEST.in (new file) with exact contents: "include requirements-core.txt\n"

Notes:

  • This change does not alter runtime behavior; it only ensures the file is available to build backends that operate in isolated temporary directories.
  • I did not modify setup.py to change how the file is read; adding MANIFEST.in addresses the immediate CI failure while keeping changes minimal as requested.

Please review and merge the PR. If you would also like me to update setup code to read requirements-core.txt relative to setup.py to make the project more robust, I can include that in this PR or a follow-up PR.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI changed the title [WIP] Add MANIFEST.in to include requirements-core.txt Include requirements-core.txt in sdist via MANIFEST.in Dec 5, 2025
Copilot AI requested a review from 4n4nd December 5, 2025 02:06
@4n4nd 4n4nd marked this pull request as ready for review December 5, 2025 02:07
@4n4nd 4n4nd merged commit 00bbce6 into master Dec 5, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants