Routes for adding users, teams and events added. Image upload to be done by KavyaChopra04 · Pull Request #1 · ACES-ACM-IITD/Website

KavyaChopra04 · 2022-08-29T12:30:37Z

No description provided.

Add files via upload

ACES-ACM-IITD

Also please install prettier as a dev-dependency and format the code.

ACES-ACM-IITD · 2022-08-30T10:23:28Z

@@ -0,0 +1,9 @@
+doctype 5


What exactly is the purpose of this file?

Nothing, was trying stuff out with image upload. Removed

ACES-ACM-IITD · 2022-08-30T10:26:06Z

+			const curr_user=await User.findOne({name : req.body.name});
+			if(curr_user==null)
+			{
+				res.json("current user not registered: error")


Please send a proper json format when using res.json. You could maintain a fixed schema while returning. For example to send an error response:

res.json( { err: true, msg: "error message here" } )

To send an ok response -

res.json({err: false, msg: ""})

ACES-ACM-IITD · 2022-08-30T10:27:12Z

+
+		}
+	})
+	app.route(adminAuth, '/addteamhere').


Rename this to /addteam. Also add a GET endpoint that renders the appropriate form for all theee viz '/addteam', '/addevent', '/adduser'

ACES-ACM-IITD · 2022-08-30T10:29:15Z

+var mongoose = require("mongoose"),
+    Schema = mongoose.Schema,
+    bcrypt = require("bcrypt"),
+    SALT_WORK_FACTOR = 10;


What is the function of SALT_WORK_FACTOR exactly?

Password hashing using bcrypt. This is the number of rounds it uses to hash passwords I believe.

ACES-ACM-IITD · 2022-08-30T10:37:22Z

+const multer = require('multer');
+const storage = multer.diskStorage({
+	destination: function(req, file, cb) {
+	  cb(null, '/public/uploads/');
+	},
+	filename: function(req, file, cb) {
+	  cb(null, new Date().toISOString() + file.originalname);
+	}
+  });
+
+  const fileFilter = (req, file, cb) => {
+	// reject a file
+	if (file.mimetype === 'image/jpeg' || file.mimetype === 'image/png') {
+	  cb(null, true);
+	} else {
+	  cb(null, false);
+	}
+  };
+
+  const upload = multer({
+	storage: storage,
+	fileFilter: fileFilter
+  });
+


If this is not working please refer to the following page from node docs utilising node-formidable. I have tried it out, and file upload works with this approach. Make sure you uninstall multer before switching to formidable.

ACES-ACM-IITD

What is the install.Unix.sh file?

ACES-ACM-IITD · 2022-08-30T10:48:17Z

 		.get(auth, function(req, res) {
 			res.render(path + '/public/user');
 		});


Let's do away with the GET and POST endpoints of '/user'. We don't need it anymore.

Again, was just trying out stuff with image upload. Removed.

ACES-ACM-IITD · 2022-08-30T10:51:28Z

+	post(async function(req,res){
+		try {
+			const yearobj = await Team.findOne({ year: req.body.year});
+			const curr_user=await User.findOne({name : req.body.name});


Change this to lookup using email

ACES-ACM-IITD

Do format the entire codebase once done, and also strip unnecessary console.log messages.

ACES-ACM-IITD · 2022-09-18T11:02:06Z

+		const user = new User(fields);
+        var oldPath = files.profile_pic.filepath;
+		console.log(__dirname)
+        var newPath = path1.join(__dirname, '/../../upload')+ '/'+fields.username


Please use path.join consistently to join path items.

Suggested change

var newPath = path1.join(__dirname, '/../../upload')+ '/'+fields.username

var newPath = path1.join(__dirname, '/../../upload', fields.username)

ACES-ACM-IITD · 2022-09-18T11:07:37Z

+		console.log(files)
+
+		const user = new User(fields);
+        var oldPath = files.profile_pic.filepath;


What exactly is oldPath ? If I am posting a file for the first time what would be the value?

ACES-ACM-IITD · 2022-09-18T11:08:26Z

+        var oldPath = files.profile_pic.filepath;
+		console.log(__dirname)
+        var newPath = path1.join(__dirname, '/../../upload')+ '/'+fields.username
+        var rawData = fs.readFileSync(oldPath)


Followup to the earlier question: Is this guaranteed to work? Does it throw any error if say oldPath does not exist on the filesystem?

ACES-ACM-IITD · 2022-09-18T11:09:41Z

+		console.log(fields)
+		console.log(files)


I believe these were debugging aids? If so please strip these console.log statements before the final merge.

ACES-ACM-IITD · 2022-09-18T11:10:56Z

+				var oldPath = (files.gallery)[i].filepath;
+				var newPath = path1.join(__dirname, '/../../upload')+ '/'+(files.gallery)[i].originalFilename
+				var rawData = fs.readFileSync(oldPath)
+				fs.writeFile(newPath, rawData, function(err){
+					if(err){console.log(err); return res.json({err: true})}
+
+				})


I think the same snippet was used in /addevent as well? Maybe abstract it out as a function?

ACES-ACM-IITD · 2022-09-18T11:13:15Z

+			const curr_user=await User.findOne({email : req.body.email});
 			if(curr_user==null)
 			{
 				res.json("current user not registered: error")


Consistent error schema?

ACES-ACM-IITD · 2022-09-18T11:15:05Z

+			let sz= files.gallery.length
+			console.log("size is ", sz)
+			for(let i=0;i<sz;i++)


Also you can use javascript's forEach method. It looks more elegant and alleviates worries about sizes and lengths 😄

ACES-ACM-IITD · 2022-09-18T11:28:18Z

+	app.route("/addteam").get(adminAuth, async function(req,res){
+		const teamobj=await Team.find()
+		const sz=teamobj.length
+		const cleanedobj = []
+		console.log(teamobj)
+		for(let i=0;i<sz;i++)
+		{
+			const newobj={}
+			newobj.year=teamobj[i].year
+			newobj.positions=[]
+			let j= teamobj[i].positions.length
+			for(let k =0;k<j;k++)
+			{
+				const secnewobj={}
+				secnewobj.position_name=teamobj[i].positions[k].position_name;
+				secnewobj.people=[]
+				let l = teamobj[i].positions[k].people.length;
+				console.log("iterating over ", teamobj[i].year, " and " , teamobj[i].positions[k].position_name, " with strength ", l)
+				for(let p=0;p<l;p++)
+				{
+					console.log("searching for ", teamobj[i].positions[k].people[p])
+					const user = await User.findOne({_id: teamobj[i].positions[k].people[p]})
+					console.log(user)
+					if(user!=null)
+					{
+						secnewobj.people.push(user.name)
+					}
+
+				}
+				newobj.positions.push(secnewobj)
+			}
+			cleanedobj.push(newobj)
+		}
+		res.json(cleanedobj)
+	})


I think I am having trouble understanding the code.
Why do we need so many loops? This endpoint is supposed to add a member to the team right? So you just need to find a team object in the given year, with the given position_name. I believe there are inbuilt methods in mongoose to execute such complicated queries. Do check them out, If not then you will have to change the schema so that you are able to directly fetch the required object with mongoose API. We don't want to write too many for loops as it makes the code incomprehensible.

sakshigupta15 and others added 14 commits August 17, 2022 23:28

Delete bank.js

d6dae8c

Delete bills.js

5fb246d

Delete withdrawRequests.js

b7df8ec

Delete moneyCollected.js

fa1c846

Add files via upload

f8a4029

Delete users.js

e5b14ff

Merge pull request #1 from KavyaChopra04/sakshigupta15-patch-1

0bbe8b5

Add files via upload

Delete eventsschema.js

312f224

Delete usersschema.js

29cf158

Add files via upload

0f6ac5f

Update Team.js

ba0812f

server runs fine, deleted banking and bills stuff

2d80672

modified users schema, added user reg route

b047336

PR init

bae1dd0

ACES-ACM-IITD requested changes Aug 30, 2022

View reviewed changes

KavyaChopra04 added 2 commits September 13, 2022 16:23

date parsing pending, rest done

99d877f

added get endpoint for user

81b3096

KavyaChopra04 closed this Sep 13, 2022

ACES-ACM-IITD reviewed Sep 18, 2022

View reviewed changes

ACES-ACM-IITD reopened this Sep 18, 2022

KavyaChopra04 added 2 commits October 5, 2022 20:09

teams fixing pending, rest done

45bad5e

teams fixing pending, rest done

b22664a

	var newPath = path1.join(__dirname, '/../../upload')+ '/'+fields.username
	var newPath = path1.join(__dirname, '/../../upload', fields.username)

Conversation

KavyaChopra04 commented Aug 29, 2022

Uh oh!

ACES-ACM-IITD left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ACES-ACM-IITD Aug 30, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ACES-ACM-IITD Aug 30, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ACES-ACM-IITD left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ACES-ACM-IITD left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ACES-ACM-IITD Aug 30, 2022 •

edited

Loading

ACES-ACM-IITD Aug 30, 2022 •

edited

Loading