refactor(config): route Megatron override compatibility through launcher policy#589
Open
WangLingxun wants to merge 3 commits intomainfrom
Open
refactor(config): route Megatron override compatibility through launcher policy#589WangLingxun wants to merge 3 commits intomainfrom
WangLingxun wants to merge 3 commits intomainfrom
Conversation
WangLingxun
requested review from
Xiaoming-AMD,
limou102 and
wenxie-amd
as code owners
WangLingxun
force-pushed
the
refactor/megatron-config-override-compat
branch
from
08b589e to
073be7c
Compare
| _setup_hooks: Dict[str, List[Callable]] = {} | ||
|
|
||
| # Backends that may accept CLI overrides not declared in module YAML presets. | ||
| _backend_unknown_cli_overrides = { |
Collaborator
There was a problem hiding this comment.
backend-special logic should not appear here（core/backend/* ）
WangLingxun
force-pushed
the
refactor/megatron-config-override-compat
branch
2 times, most recently
from
5304fb8 to
f4d293b
Compare
…her policy - Declare the unknown CLI override passthrough in the Megatron module preset so the compatibility rule stays with the preset it applies to. - Read the generic launcher policy during parsing and preserve it through runtime normalization so legacy Megatron overrides remain compatible without backend-specific branching.
WangLingxun
force-pushed
the
refactor/megatron-config-override-compat
branch
from
f4d293b to
012f82d
Compare
WangLingxun
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.