fix(runner): prioritize ROCm libraries across pretrain launchers#649
Merged
WangLingxun merged 3 commits intomainfrom Apr 13, 2026
Merged
fix(runner): prioritize ROCm libraries across pretrain launchers#649WangLingxun merged 3 commits intomainfrom
WangLingxun merged 3 commits intomainfrom
Conversation
Keep /opt/rocm/lib ahead of system library paths in the base env, AINIC hooks, and legacy run_pretrain flow so rocm/primus:v26.2 does not load an incompatible HSA runtime. Add shared path helpers to dedupe LD_LIBRARY_PATH updates while preserving user-provided entries.
WangLingxun
requested review from
Xiaoming-AMD,
limou102 and
wenxie-amd
as code owners
Xiaoming-AMD
previously approved these changes
Apr 10, 2026
Resolve AINIC hook conflicts by keeping the new hook-based flow and preserving ROCm-first LD_LIBRARY_PATH handling with deduplicated path updates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep /opt/rocm/lib ahead of system library paths in the base env, AINIC hooks, and legacy run_pretrain flow so rocm/primus:v26.2 does not load an incompatible HSA runtime. Add shared path helpers to dedupe LD_LIBRARY_PATH updates while preserving user-provided entries.