EVB2 cleanup per review comments#378
Open
mastbaum wants to merge 11 commits intoANNIEsoft:Applicationfrom
Open
EVB2 cleanup per review comments#378mastbaum wants to merge 11 commits intoANNIEsoft:Applicationfrom
mastbaum wants to merge 11 commits intoANNIEsoft:Applicationfrom
Conversation
deferring proposed improvements to regex matching and path configs.
Removing the RingCounting v1.0.0 model here, but not pruning it from the git repo to avoid rewriting history. The config is updated to point to the model directory that already exists on pnfs rather than a user directory.
Note: it may be more efficient to allocate this once rather than within the loop, but this is a minimal fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses review comments on #334, #336, #337, #338, #339, #340, and #373 (i.e., the EVB v2 suite).