Skip to content

Nutrient constrained growth - #10128

Open
byzheng wants to merge 4 commits into
APSIMInitiative:masterfrom
byzheng:nutrient-constrained-growth
Open

Nutrient constrained growth#10128
byzheng wants to merge 4 commits into
APSIMInitiative:masterfrom
byzheng:nutrient-constrained-growth

Conversation

@byzheng

@byzheng byzheng commented Jul 1, 2025

Copy link
Copy Markdown
Contributor

Working on #3605

The nutrient constrain growth check the new minimum nitrogen concentration in each organ to limit daily actual growth.

The minimum nitrogen concentration is a measured trait for whole organ, instead of new organ.

The proposed changes apply nitrogen constrain to whole organ. Check the performance for all validation test.

@hol353

hol353 commented Oct 14, 2025

Copy link
Copy Markdown
Contributor

@hut104 and @HamishBrownPFR: Can you look at this PR? It is only a small change but might have a big impact.

@byzheng

byzheng commented Oct 22, 2025

Copy link
Copy Markdown
Contributor Author

We had a discussion with @hut104, @HamishBrownPFR, and @EnliWang about this change. Here is my current understanding (which might not be entirely correct):

  • The original approach is based on a physiological perspective:
    The parameter minimum nitrogen concentration represents the minimum nitrogen requirement for the developing portion of an organ. The developing organ may require different minimum nitrogen concentrations at different stages.
    For example, in wheat, grains initially fill with proteins (which require higher nitrogen), and later with starch (which requires less nitrogen).

  • My modification is based on an observable (empirical) perspective:
    The parameter minimum nitrogen concentration represents the minimum nitrogen requirement for the entire organ, which can be measured directly from field experiments.

To address the issue in #3605 for wheat and canola, an alternative approach proposed by @hut104 and @HamishBrownPFR would be to make the minimum nitrogen concentration stage-dependent — using a curve instead of a constant, with much smaller values toward the end of grain filling.

@github-actions

Copy link
Copy Markdown

This Pull Request has been automatically marked as stale because it has not had activity in the last 60 days. Please leave a comment if this should stay open, otherwise this pull request will be closed in 7 days. This helps keep our list of active projects separate from work that is on hold.

@github-actions github-actions Bot added the Stale label Dec 22, 2025
@github-actions

Copy link
Copy Markdown

This Pull Request was closed because it has been inactive for 60 days. Feel free to re-open when you are ready to continue.

@github-actions github-actions Bot closed this Dec 29, 2025
@par456

par456 commented Jan 4, 2026

Copy link
Copy Markdown
Collaborator

The bot shouldn't have closed this yet, reopening.

@par456 par456 reopened this Jan 4, 2026
@github-actions github-actions Bot removed the Stale label Jan 5, 2026
@par456 par456 added the Do Not Merge Used for PRs that should not be merged for any reason label Jan 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Do Not Merge Used for PRs that should not be merged for any reason

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants