Skip to content

FIX: Units recognition for act_accumulate_precip - #1068

Merged
zssherman merged 1 commit into
ARM-DOE:mainfrom
rcjackson:accumulate_precip_fix
Oct 6, 2026
Merged

zssherman merged 1 commit into
ARM-DOE:mainfrom
rcjackson:accumulate_precip_fix

Conversation

@rcjackson

Copy link
Copy Markdown
Collaborator

What changed

2-4 bullets in plain language.

  • The units were not being properly recognized for accumulate_precip.
  • Units that require a conversion from mm/hr to mm/min can be in many forms (i.e. "mm/hour"). LDQUANTS has its accumulations in "mm/hour"

Why

1-2 lines on the user/problem impact.

  • Any LDQUANTS accumulations were too high by a factor of 60.

Issues closed

List issue references this PR closes (for example: Closes #123, Fixes #456).

Validation

Mark each item as done or N/A. Add one short evidence line for each item.

  • I ran pre-commit or ruff

  • I ran tests and/or added tests

AI usage & manual verification

If AI tools were used, complete this section.

  • AI used: yes
  • Model/tooling: Codex/GPT 5.6-Luna
  • Tasks delegated to AI: Finding the error while making a radclss notebook. Code inserted manually.
  • Manual verification performed: Yes

Use Xarray Dataset naming

When adding dataset usage to the code use ds for Datasets and da for
DataArrays

Impact note (optional): breaking behavior, scientific output shift, or user-visible behavior.

@zssherman zssherman closed this Oct 6, 2026
@zssherman zssherman reopened this Oct 6, 2026
@zssherman
zssherman merged commit d8c975c into ARM-DOE:main Oct 6, 2026
20 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants