Skip to content

CI: FInal updates for ci workflows. - #1901

Merged
zssherman merged 2 commits into
ARM-DOE:mainfrom
zssherman:lint_update
Oct 15, 2026
Merged

zssherman merged 2 commits into
ARM-DOE:mainfrom
zssherman:lint_update

Conversation

@zssherman

@zssherman zssherman commented Oct 15, 2026 •

Copy link
Copy Markdown
Collaborator

PR tags (required)

Select all that apply.

  • docs-only
  • tests-only
  • tiny-change (<5 lines of code in 1 or 2 files)
  • big refactor
  • scientific/algorithmic
  • design/architecture

What changed

2-4 bullets in plain language.

  • Added final security features

Why

1-2 lines on the user/problem impact.
further improves CI security

Issues closed

List issue references this PR closes (for example: Closes #123, Fixes #456).

Target version

Select one.

  • next patch
  • next minor
  • next major

Validation

Mark each item as done or N/A. Add one short evidence line for each item.

  • I ran pre-commit or ruff

  • I ran tests

AI usage & manual verification

If AI tools were used, complete this section.

  • AI used: no
  • Model/tooling:
  • Tasks delegated to AI:
  • Manual verification performed:

Manual verification

Mark each item as done or N/A. Add one short evidence line or N/A reason for each item.

  • For scientific/algorithmic or result-changing PRs, I provided an example notebook.

    • Notebook link/path or N/A reason:
  • I compared before-and-after outputs and stated whether results changed.

    • Evidence or N/A reason:
  • I checked results against a known baseline or expected values.

    • Evidence or N/A reason:
  • I manually exercised relevant edge cases.

    • Evidence or N/A reason:
  • I checked backward compatibility or API behavior.

    • Evidence or N/A reason:

Impact note (optional): breaking behavior, scientific output shift, or user-visible behavior.

@zssherman
zssherman requested a review from RBhupi October 15, 2026 20:21
@review-notebook-app

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@zssherman
zssherman merged commit 24f73ae into ARM-DOE:main Oct 15, 2026
16 checks passed
@zssherman
zssherman deleted the lint_update branch October 15, 2026 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant