Add SBMR self-declaration hooks and align config with SBMR checklist#48
Merged
Conversation
Guru9902
commented
Feb 9, 2026
Guru9902
commented
Contributor
- Add self-declaration tests and variables for uncovered M3/M4/M5a rules (Side-Band, JTAG, IO, OOB, SPDM, RAS, In-Band, Host-to-SatMC).
- Update checklist doc to reference the new declaration tags.
- Reorder config self-declaration entries to follow SBMR checklist.
gtossk2
reviewed
Feb 9, 2026
gtossk2
reviewed
Feb 9, 2026
| @@ -1,27 +1,44 @@ | |||
| # M1 Level | |||
| # In-Band | |||
Contributor
There was a problem hiding this comment.
Please run the test cases to ensure everything works correctly after reordering them.
There was a problem hiding this comment.
If possible, please attach test report in PR for reference.
Contributor
Author
There was a problem hiding this comment.
without changes : sbmr_main.zip
with changes : sbmr_with_declaration.zip
Contributor
There was a problem hiding this comment.
@amrathesh @Guru9902 Would we run this on a stable machine?
gtossk2
reviewed
Feb 9, 2026
Guru9902
force-pushed
the
declaration
branch
from
February 10, 2026 05:57
f3e71e8 to
56e1987
Compare
Member
|
@anncheng-arm Please review this PR. |
Guru9902
force-pushed
the
declaration
branch
5 times, most recently
from
February 20, 2026 07:00
77d9f35 to
e92e280
Compare
gtossk2
reviewed
Feb 23, 2026
gtossk2
reviewed
Feb 23, 2026
gtossk2
reviewed
Feb 23, 2026
gtossk2
reviewed
Feb 23, 2026
gtossk2
reviewed
Feb 23, 2026
gtossk2
reviewed
Feb 23, 2026
gtossk2
reviewed
Feb 23, 2026
gtossk2
reviewed
Feb 23, 2026
gtossk2
reviewed
Feb 23, 2026
gtossk2
reviewed
Feb 23, 2026
Guru9902
force-pushed
the
declaration
branch
from
February 25, 2026 09:35
e92e280 to
06fb42f
Compare
- Add self-declaration tests and variables for uncovered M3/M4/M5a rules
(Side-Band, JTAG, IO, OOB, SPDM, RAS, In-Band, Host-to-SatMC).
- Update checklist doc to reference the new declaration tags.
- Reorder config self-declaration entries to follow SBMR checklist.
- docs: add side-band rule links in SBMR checklist
Signed-off-by: gurrev01 <gururaj.revankar@arm.com>
Guru9902
force-pushed
the
declaration
branch
2 times, most recently
from
March 4, 2026 11:42
58773d8 to
4bf0c0e
Compare
gtossk2
reviewed
Mar 4, 2026
gtossk2
reviewed
Mar 4, 2026
gtossk2
reviewed
Mar 4, 2026
gtossk2
reviewed
Mar 4, 2026
gtossk2
reviewed
Mar 4, 2026
gtossk2
reviewed
Mar 4, 2026
Signed-off-by: gurrev01 <gururaj.revankar@arm.com>
gtossk2
approved these changes
Mar 5, 2026
gtossk2
left a comment
gtossk2
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the changes. Look good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.