Fix M1_UART_2_IPMI_SOL, M2_OOB_1_Redfish_Reference_Checker, and M1_UART_1_Redfish_Serial_Console_Capability test failures#49
Merged
Conversation
Robot Framework processes single-backslash escape sequences (e.g. \[, \]) before passing the pattern to Python's re module, resulting in an 'unbalanced parenthesis' error at runtime. Double the backslashes in the regex pattern so that Robot Framework passes literal backslash-bracket sequences to re.search: Before: \[(tty[^\]]+)\] After: \\[(tty[^\\]]+)\\] This fixes the 'Verify BSA Compliant UART From Boot Log' keyword in the M1_UART_2_IPMI_SOL test case.
The Redfish Reference Checker (html_scraper) requires beautifulsoup4 and lxml to parse HTML responses from the BMC. Without these packages the test fails at import time with a ModuleNotFoundError. Add beautifulsoup4 and lxml to requirements.txt so they are installed during environment setup.
…nsole schema ComputerSystem v1.13.0+ uses HostSerialConsole type with named sub-objects (IPMI, SSH, Telnet, WebSocket) instead of Manager schema's ConnectTypesSupported array. Test now checks Systems first, falls back to Managers, and validates using set intersection against known connection types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes three test failures discovered during SBMR-ACS compliance testing against a Supermicro BMC.
Commits
1. fix(M1_UART_2_IPMI_SOL): escape regex brackets for Robot Framework
Robot Framework processes
\[and\]as escape sequences before passing the pattern to Python'sremodule, causing an "unbalanced parenthesis" error. Fixed by doubling the backslashes so the regex reachesre.searchintact.2. fix(M2_OOB_1_Redfish_Reference_Checker): add missing Python dependencies
The Redfish Reference Checker's
html_scrapermodule requiresbeautifulsoup4andlxml. Added both torequirements.txt.3. fix(M1_UART_1_Redfish_Serial_Console_Capability): handle HostSerialConsole schema
The original test assumed all SerialConsole responses contain a
ConnectTypesSupportedarray (Manager schema). ComputerSystem schema v1.13.0+ uses theHostSerialConsoletype with named sub-objects (IPMI,SSH,Telnet,WebSocket) instead. Fixed by:Testing
All three tests pass against the Supermicro BMC (OpenBMC-based, Redfish ComputerSystem v1.13.0+).