Remember repeatable Quest turn-ins so Breadcrumbs into them can lock - #2537
Open
Blackbear123 wants to merge 1 commit into
Open
Remember repeatable Quest turn-ins so Breadcrumbs into them can lock#2537Blackbear123 wants to merge 1 commit into
Blackbear123 wants to merge 1 commit into
Conversation
The game unflags a repeatable Quest the instant it is turned in, so IsQuestFlaggedCompleted never reports one as completed. LockedAsBreadcrumb asks exactly that question of every nextQuest, which means a Breadcrumb whose nextQuests are all repeatable can never be detected as locked - it stays collectible forever, and turning Locked Quests off does not remove it either, because nothing ever marked it locked. The Quartermaster (7121) in Alterac Valley is the case in hand: its nextQuests are Irondeep Supplies (5892) and Coldtooth Supplies (6982), both repeatable. Once either has been handed in the Breadcrumb can no longer be picked up, and ATT has no way to know. QUEST_TURNED_IN is the only record that a repeatable turn-in happened, so it is now remembered per character, and the Breadcrumb and lockCriteria checks read it alongside the completion flag. Only Quests some Breadcrumb points at are stored, so the saved variable stays small. This can only work from the turn-in onwards; a repeatable Quest handed in before this change leaves no trace anywhere to recover. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
LockedAsBreadcrumbtestsIsQuestFlaggedCompleted(nextQuestID). The game unflags arepeatable Quest the instant it is turned in, so that can never return true. A Breadcrumb
whose nextQuests are all repeatable can never be detected as locked.
The Quartermaster (7121) in Alterac Valley is the case in hand: nextQuests = {5892, 6982},
Irondeep Supplies and Coldtooth Supplies, both repeatable=1 in ATT's own data. Once either
has been handed in the Breadcrumb can no longer be picked up.
Turning off Locked Quests does not remove it either, because
CollectibleAsLockedgates ont.lockedand nothing ever set it.Fix
QUEST_TURNED_IN fires with the questID for repeatable Quests too, and is the only record
that will ever exist. It is remembered per character in
currentCharacter.RepeatableQuests,and the Breadcrumb and lockCriteria questID checks read it alongside the completion flag.
Only Quests some Breadcrumb points at are stored, so the saved variable cannot grow.