Skip to content

Feature/migrate to project structure#7

Open
miroslavpojer wants to merge 6 commits intomasterfrom
feature/migrate-to-project-structure
Open

Feature/migrate to project structure#7
miroslavpojer wants to merge 6 commits intomasterfrom
feature/migrate-to-project-structure

Conversation

@miroslavpojer
Copy link
Contributor

@miroslavpojer miroslavpojer commented Mar 6, 2026

Release Notes:

  • Refactored repository structure.

@miroslavpojer miroslavpojer self-assigned this Mar 6, 2026
category = classify_category(alert)

values: dict[str, Any] = {
"category": category or NOT_AVAILABLE,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, that since I do give you some input in every situation (I add "N/A") You do not need to have a NOT_AVAILABLE part.

Copy link
Collaborator

@tmikula-dev tmikula-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do like this structure much more! Good first phase of getting this project back to our standard.

  • I still want to suggest to put the security and shared folders inside new src/. Better for mirroring unit test folder against the src. Right now you are not testing the shared folder logic at all.
  • You are having at the moment two workflow files. I had to read the documentation to find out, that the one inside the security is just example caller. I am suggesting to move this examples inside the docs/security/security.md + docs/security/example_workflows/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants