Open
Conversation
tmikula-dev
reviewed
Mar 9, 2026
| category = classify_category(alert) | ||
|
|
||
| values: dict[str, Any] = { | ||
| "category": category or NOT_AVAILABLE, |
Collaborator
There was a problem hiding this comment.
I think, that since I do give you some input in every situation (I add "N/A") You do not need to have a NOT_AVAILABLE part.
tmikula-dev
reviewed
Mar 9, 2026
Collaborator
tmikula-dev
left a comment
There was a problem hiding this comment.
I do like this structure much more! Good first phase of getting this project back to our standard.
- I still want to suggest to put the security and shared folders inside new src/. Better for mirroring unit test folder against the src. Right now you are not testing the shared folder logic at all.
- You are having at the moment two workflow files. I had to read the documentation to find out, that the one inside the security is just example caller. I am suggesting to move this examples inside the docs/security/security.md + docs/security/example_workflows/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Notes: