🌊 - Beatrice - #21
Open
Beatress wants to merge 2 commits into
Open
Conversation
CheezItMan
reviewed
Mar 24, 2021
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Well done Beatrice, you hit the learning goals here. Well done.
Comment on lines
+21
to
23
| # Time Complexity: O(1) | ||
| # Space Complexity: O(1) | ||
| def add_first(value) |
Comment on lines
+30
to
32
| # Time Complexity: O(n) - Must traverse list | ||
| # Space Complexity: O(1) | ||
| def search(value) |
| def find_max | ||
| raise NotImplementedError | ||
| current = @head | ||
| max = current&.data |
Author
There was a problem hiding this comment.
This is to avoid an error stating that there is no such method .data for nil
Comment on lines
+44
to
46
| # Time Complexity: O(n) - Must traverse list | ||
| # Space Complexity: O(1) | ||
| def find_max |
Comment on lines
+61
to
63
| # Time Complexity: O(n) - Must traverse list | ||
| # Space Complexity: O(1) | ||
| def find_min |
Comment on lines
+120
to
122
| # Time Complexity: O(n) - Must traverse list | ||
| # Space Complexity: O(1) | ||
| def get_at_index(index) |
Comment on lines
+134
to
136
| # Time Complexity: O(n) - Must traverse list | ||
| # Space Complexity: O(1) | ||
| def visit |
Comment on lines
+147
to
149
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def delete(value) |
Comment on lines
+173
to
175
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def reverse |
Comment on lines
+192
to
194
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def get_last |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.