Water - Jessica - #38
Open
jwinchan wants to merge 2 commits into
Open
Conversation
CheezItMan
reviewed
May 21, 2021
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Overall nice work Jessica. I did find a small error in add_last. Otherwise quite well done.
Comment on lines
+21
to
23
| # Time Complexity: O(1) | ||
| # Space Complexity: O(1) | ||
| def add_first(value) |
Comment on lines
+30
to
32
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def search(value) |
Comment on lines
+46
to
48
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def find_max |
Comment on lines
+63
to
65
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def find_min |
Comment on lines
+82
to
84
| # Time Complexity: O(1) | ||
| # Space Complexity: O(1) | ||
| def get_first |
Comment on lines
+116
to
119
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
|
|
||
| def get_at_index(index) |
Comment on lines
+135
to
137
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def visit |
Comment on lines
+94
to
+97
| until current.nil? | ||
| current = current.next | ||
| end | ||
| current = Node.new(value) |
There was a problem hiding this comment.
This was not linking in the new node to the list.
Suggested change
| until current.nil? | |
| current = current.next | |
| end | |
| current = Node.new(value) | |
| if @head.nil? | |
| self.add_first(value) | |
| end | |
| until current.next.nil? | |
| current = current.next | |
| end | |
| current.next = Node.new(value) | |
| @@ -106,7 +177,11 @@ def reverse | |||
| # Time Complexity: ? | |||
| # Space Complexity: ? | |||
| def get_last | |||
Comment on lines
+149
to
152
| # 0 1 2 nil | ||
| # 2 | ||
|
|
||
| def delete(value) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.