Fix #239237 www.nikkei.com - #239250
Fix #239237 www.nikkei.com#239250
Conversation
| baseball.yahoo.co.jp##.bb-centerColumn > #inf:has(> .sn-modNotice > .sn-notice--annapurna) | ||
| nikkei.com##div[data-rn-inview-track="hub-ad-recommend"] | ||
| nikkei.com##div[class^="trendWatchContainer_"] | ||
| nikkei.com##body > div[class^="adsArea_"] |
There was a problem hiding this comment.
Yes. I tested It and It was intended. I will recheck tomorrow for narrowing rules 👀
There was a problem hiding this comment.
Yeah, that hides too much. Also neither of the above two rules (##div[data-rn-inview-track="hub-ad-recommend"], ##div[class^="trendWatchContainer_"] hits on my end, either on mobile or on desktop. On my end "トレンドウォッチ" is ##div[class^="trendWatchList_"] and what's reported will require something like ##div[class^="item_"]:has(> a[class^="commonStylesAnchor_"][href*="/?utm_source="]).
There was a problem hiding this comment.
On my end other rules applied on another pages.
There was a problem hiding this comment.
Okay, found them on the top page, but but hub-ad-recommend can be added to the Japanese filter. I'll add it.##div[data-rn-inview-track="hub-ad-recommend"] hides too much on mobile. Maybe something like ##div[data-rn-track="hub-ad-recommend"]:has(> a[href*="/?utm_source="]).
There was a problem hiding this comment.
The ##div[class^="trendWatchContainer_"] container is still make sense. because It incudes self-promotion contents. By the way It has incorrect blocking in AdGuard. I'm checking this issue now.
Adbocker Enabled / Disabled
There was a problem hiding this comment.
I've found the reason. The self-promo content is served under nkis.nikkei.com, which is blocked by adserver.txt in JapaneseFilter.
I have listed self-promotion requests below, but they didn't work due to ||nkis.nikkei.com.
! nikkei.com self-promo widget [data-kad-id="5226_7151"][data-kad-type="trendwatch"], confirmed serving content
@@||nkis.nikkei.com/ad?*section_id=7151&*$domain=nikkei.com
@@||nkis.nikkei.com/ad?*section_id=7153&*$domain=nikkei.com
@@||nkis.nikkei.com/ad?*section_id=10810&*$domain=nikkei.com
@@||nkis.nikkei.com/ad?*section_id=7155&*$domain=nikkei.com
!
! nikkei.com self-promo widget [data-kad-id="5225_7149"][data-kad-type="infeed-wide"]
@@||nkis.nikkei.com/ad?*section_id=7149&*$domain=nikkei.comRequest URL example:
nkis.nikkei.com/ad?ord=6724574257231§ion_id=7149&handler_name=process_tag_provider_response_7149
What should I do about this issue?
There was a problem hiding this comment.
In this case it's okay to keep them blocked. It requires too many exceptions, and sometimes we just let recommendations blocked than adding exceptions - other times not and all these depend on various factors.
|
@Alex-302 Please merge this PR 👀 |
3 participants
Prerequisites
To avoid invalid pull requests, please check and confirm following terms
What problem does the pull request fix?
If the problem does not fall under any category that is listed here, please write a comment below in corresponding section
What issue is being fixed?
Enter the issue address
Add your comment and screenshots
Terms