Fix/parse filter ids whitespace - #1227
Conversation
|
Why? |
de718bd to
1bf836b
Compare
|
The change addresses issue #1223. On Windows PowerShell, an unquoted This PR accepts both comma- and whitespace-separated IDs, rejects malformed IDs, |
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR improves parsing of --include / --skip filter ID lists, especially for Windows/PowerShell invocation quirks, by centralizing parsing and tightening validation.
Changes:
- Introduced a shared
parseFilterIDshelper that accepts comma- or whitespace-separated IDs and rejects malformed tokens. - Updated existing build/patch scripts to use the shared parser instead of ad-hoc
split(',') + parseInt. - Refreshed tests and developer documentation to reflect the new parsing rules.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/build/patches.js | Switch include/skip parsing to shared parseFilterIDs. |
| scripts/build/filter-id-list.js | Add centralized parsing + validation for filter ID lists. |
| scripts/build/build-config.ts | Use parseFilterIDs in parseFlags to unify behavior and validation. |
| scripts/build/tests/build-config.test.ts | Add coverage for whitespace-separated values and invalid token rejection. |
| DEVELOPMENT.md | Document comma/whitespace support for include/skip flags. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
1bf836b to
d3358d3
Compare
|
Addressed the requested changes in the latest push: the shared parser is now TypeScript, JSDoc types were removed, parsing uses native string/number functions instead of regex, invalid IDs retain the previous filter-out behavior, and the whitespace examples are quoted and explained. Rebased onto current |
|
All review threads are addressed in the current branch and have been marked resolved. Fresh verification on current |
No description provided.