docs: fix 7 typos in comments and log messages - #353
Closed
Avicennasis wants to merge 1 commit into
Closed
Conversation
Member
|
Thank you for opening a PR. This public repository is a mirror of our private repository. Since the changes are now upstream, I will close this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Fixes 7 typos in comments, JSDoc and two debug log strings. No logic changes.
collpased->collapsedwithin 2 sec of of mouseleave event->within 2 sec of mouseleave eventmaps iframe elements to its contentDocument->their contentDocument(the antecedentelementsis plural)log.print('MesageHub: received a message from a port')->MessageHublog.print('MesageHub: sending a message to a port')->MessageHubBuild query string for downloading tranlations->translationsBuild form data for uploading tranlation->translationThe two
InterContextMessageHubchanges are the only ones that touch executable lines: they are the textinside
log.print(...)debug messages, and they are already spelledMessageHubon lines 50 and 56 of thesame file, so this only makes the log output self-consistent. Worth a careful look all the same, since they
are string literals rather than comments. I grepped the whole repository (including
test/) forMesageHub:the two lines changed here are the only occurrences, so no test assertions or other call sites depend on the
old spelling.
Testing Instructions
No runtime behaviour changes, so there is nothing to test functionally.
git diffshows 7 changed linesacross 4 files, all inside comments or debug log strings.
Browser Support
Manifest version:
(N/A - userscript, no manifest involved.)
Affected Areas
Comments and JSDoc in
src/ui/alert/,src/proxy/,src/messaging/and thelocales.tsbuild script,plus two debug log strings in
src/messaging/InterContextMessageHub.ts.Backward Compatibility
Additional Notes
Two notes on your conventions, since I am an outside contributor:
AGENTS.mdrequires commit messages to start with anAG-XXXticket number. I do not have a trackerticket, so I used the Conventional Commits fallback the same section allows (
docs:). Happy to reword orrebase if you would rather attach a ticket number.
CHANGELOG.mdentry, since nothing user-facing changed. Glad to add one if you prefer.Not fixed here, but noticed on the same line as the
ChildContextInjectorchange:Weakmapwould moreconventionally be spelled
WeakMap, matching theIWeakMaptype on the next line. Left alone to keep this PRto the verified set.