Correct legacy owned-buyer activity attribution - #184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The conversion report counted historical AG-operated buyer tests in its external task bucket because it checked only the original first-party flag. It also ignored later account and agent ownership corrections when classifying old flow events.
Use the shared exact-ID ownership rule for task parties and the account-aware classifier for flow events. Add the two July 13 buyers proved by the committed Hello World and PaKi run artifacts. These were sandbox-credit runs with no provider payout. External providers and two similar but unproved buyer identities retain their attribution; historical tasks, events, attestations and cash records are not rewritten. The report becomes
conversion-activity-v3and explains the change in comparability.Validation: full local JSON suite passed 2,112 tests with 10 skipped; final focused suite passed 41 tests, including the four added current-ownership cases. New regressions run against JSON and SQLite and cover owned buyers/workers, immutable historical evidence, current account/agent flags, missing records, and narrow identity boundaries. Full hosted certification and deployment checks run through the protected ship workflow.