Fix for SD card block operations keyed access - #208
Open
sijnstra wants to merge 2 commits into
Open
Conversation
stevesims
reviewed
Jul 15, 2026
stevesims
left a comment
stevesims
left a comment
Contributor
There was a problem hiding this comment.
awesome stuff
functionally I think it looks great
I've made a few minor suggestions around naming and typing that I think might be good to do whilst we're here
Author
|
Makes sense to keep the word code consistent for readability, so that's done now. You'll also see I've tidied the int to be UINT24 (it really didn't like uint24_t), but I've left DWORD as-is because it is throughout the code in similar uses around the fatfs code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also added matching struct for ease of reading C source.