Skip to content

Support Loopback 4#862

Open
timokoessler wants to merge 10 commits intomainfrom
loopback4
Open

Support Loopback 4#862
timokoessler wants to merge 10 commits intomainfrom
loopback4

Conversation

@timokoessler
Copy link
Copy Markdown
Member

@timokoessler timokoessler commented Dec 19, 2025

Summary by Aikido

Security Issues: 0 🔍 Quality Issues: 4 Resolved Issues: 0

🚀 New Features

  • Added LoopBack integration with body parsing and route parameter handling

⚡ Enhancements

  • Enabled callback-on-block handling for interceptors and added helper utility

More info

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 17, 2026

Codecov Report

❌ Patch coverage is 97.27891% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
library/sources/LoopBack.ts 96.22% 3 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@timokoessler timokoessler changed the title Support loopback web framework Support loopback v4 Apr 17, 2026
@timokoessler timokoessler changed the title Support loopback v4 Support Loopback 4 Apr 23, 2026
@timokoessler timokoessler marked this pull request as ready for review April 23, 2026 14:43
Comment thread library/agent/hooks/wrapExport.ts
Comment thread library/sources/LoopBack.ts
Comment thread library/sources/LoopBack.ts
@@ -0,0 +1,9 @@
// Finds the last function argument in the provided array and returns it. If no function is found, it returns undefined.
Copy link
Copy Markdown
Contributor

@aikido-pr-checks aikido-pr-checks Bot Apr 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Top-line comment restates the function's behavior. Remove it or replace with a brief explanation of why finding the last callback is necessary for callers.

Suggested change
// Finds the last function argument in the provided array and returns it. If no function is found, it returns undefined.
// Extracts the callback from variadic arguments to support Node.js APIs that accept an optional callback as the last parameter.
Details

✨ AI Reasoning
​A comment was added that simply restates the implementation: it describes iterating arguments to find the last function and returning undefined otherwise. This provides no design rationale or higher-level context and thus is a 'what' comment that increases maintenance burden.

Reply @AikidoSec feedback: [FEEDBACK] to get better review comments in the future.
Reply @AikidoSec ignore: [REASON] to ignore this issue.
More info

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant