Repository navigation
Support PREPARE, EXECUTE and DEALLOCATE PREPARE to close #2863 - #3038
Open
mateuscmtropical wants to merge 2 commits into
Open
mateuscmtropical wants to merge 2 commits into
mateuscmtropical wants to merge 2 commits into
Conversation
# Conflicts: # src/alasqlparser.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2863
What was wrong
PREPARE name FROM 'text',EXECUTE name [USING @var, ...]andDEALLOCATE PREPARE namewere parse errors.What changed
PREPAREonly in the formPREPARE name FROM, andDEALLOCATE PREPAREas one token, soprepareanddeallocatestill work as column names.EXECUTEalready is a token (it reads asCALL), andCALL name [USING @a, ...]is added next toCALL func(). The grammar still has 282 conflicts.Preparedstatement keeps the text by name inalasql.prepared.PREPAREparses the text at once, so a syntax error shows there. The text can also come from a variable (PREPARE s FROM @q), as in MySQL.EXECUTEruns the text withalasql.dexecin the current database, with the values of theUSINGvariables as the?parameters. Names are not case sensitive, as in MySQL.EXECUTEorDEALLOCATE PREPAREof an unknown name throws "Unknown prepared statement".Tests
test/test2863.jscovers the statements from the issue, the text from a variable with two parameters, names in another case, the errors,EXECUTE func(), and columns namedprepareanddeallocate. The new statements are parse errors without the fix.yarn test-onlygives 2555 pass. The only failures are the 5Test 418cases that load files from the internet.