Repository navigation
Support MySQL system variables: @@name, SET @@name, SET GLOBAL and SET NAMES to close #2862 - #3039
Open
mateuscmtropical wants to merge 2 commits into
Open
mateuscmtropical wants to merge 2 commits into
mateuscmtropical wants to merge 2 commits into
Conversation
# Conflicts: # src/alasqlparser.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2862
What was wrong
MySQL's system variables were parse errors:
@@name,@@session.name,SET @@name = ...,SET GLOBAL name = ...,SET SESSION name = ...andSET NAMES charset.What changed
alasql.sysvarsobject holds the system variables. Names are lower case, as MySQL's are not case sensitive.@@nameand@@global.name,@@session.nameor@@local.nameas aSYSVARtoken. It is aVarValuewith asystemflag, which readsalasql.sysvarsand is NULL when the variable is not set.SET @@name = ...,SET GLOBAL|SESSION|LOCAL|PERSIST name = ...andSET NAMES xstore intoalasql.sysvars.SET name = valuekeeps what it does today and also stores the value, so@@namereads it back as the issue asks.SET GLOBALand the others are only tokens beforename =, andSET NAMESonly right afterSET, soglobal,sessionandnamesstill work as column names. The grammar still has 282 conflicts.Tests
test/test2862.jscovers each form from the issue, an unknown variable, and columns namedglobal,sessionandnames. The new forms are parse errors without the fix.yarn test-onlygives 2556 pass. The only failures are the 5Test 418cases that load files from the internet.