Skip to content

Job ReferenceReplacementJob is obsolete, Replacing it with running pipeline "replaceItemReferences", also creating helper method to update links when creating items of branch templates - #6

Open
aokour wants to merge 1 commit into
AlenPelin:masterfrom
aokour:master
Open

Job ReferenceReplacementJob is obsolete, Replacing it with running pipeline "replaceItemReferences", also creating helper method to update links when creating items of branch templates#6
aokour wants to merge 1 commit into
AlenPelin:masterfrom
aokour:master

Conversation

@aokour

@aokour aokour commented Nov 6, 2017

Copy link
Copy Markdown

Job ReferenceReplacementJob is obsolete, Replacing it with running pipeline "replaceItemReferences", also creating helper method to update links when creating items of branch templates

…ne "replaceItemReferences", also creating helper method to update links when creating items of branch templates
@aokour

aokour commented Nov 6, 2017

Copy link
Copy Markdown
Author

As of Sitecore 8.2 Update 5, Job ReferenceReplacementJob is obsolete and sitecore asks to use pipeline "replaceItemReferences"instead, Also added support to update links for items created of branch items

@AlenPelin

Copy link
Copy Markdown
Owner

Thanks @aokour for contributing to the project. I had a quick look at your pull request and it seems you included too much changes so it is hard to see what is important.

May I ask you to keep only functional changes, so we can focus on important part?

P.S. Parts of these project already available in Sitecore 9.0.0 out of the box, others will be merged into next releases - so there is a chance for getting your contribution merged into the product itself :)

@aokour

aokour commented Nov 27, 2017

Copy link
Copy Markdown
Author

I will clean the pull request to only keep the functional changes and re-submit this again this week

@AlenPelin

Copy link
Copy Markdown
Owner

Thank you! I will look forward your update.

@cassidydotdk

Copy link
Copy Markdown

Yea there's definitely too much stuff in there. Kamsar's Branch presets and specific branch handling code has been included - none of this is necessary using SmartCommands.

@AlenPelin

Copy link
Copy Markdown
Owner

I noticed this project is getting more attention these days. I feel I need to revise and update it with current mainstream Sitecore 8.2+

@cassidydotdk

Copy link
Copy Markdown

The fundamental Sitecore problem these commands solve has been relevant since the dawn of time ;-)

I guess SXA drove them to bring the ReferenceReplacementJob into the core product. Now we just need them to realise what people actually expect when they're duplicating a tree with internal references.

@rbrunneratnamics

Copy link
Copy Markdown

I made a running version out of aoukur's version:
https://github.com/aokour/Sitecore-Smart-Commands
combined with an older version of your source AlenPelin. It runs on a Sitecore 8.2 solution, but would be nice to run on Sitecore 9+ too.

@cassidydotdk

Copy link
Copy Markdown

My version runs just fine on 9.1.1. Which is largely if not completely based on this branch. Mind you I've included the project on source level so I compile it against a 9.1.1.

9.2 will mostly involve changes around the ReferenceReplacementJob. Invoking it via reflection solves that problem in a cross version boundary.

@markgibbons25

markgibbons25 commented Feb 18, 2021

Copy link
Copy Markdown

In Sitecore 10 ReferenceReplacementJob is not obsolete, however I see that this PR is actually just using the ReplaceItemReferences pipeline which instantiates ReferenceReplacementJob.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants