Draft
Conversation
Agent-Logs-Url: https://github.com/AlexLipp/POOPy/sessions/13f67bda-0a40-4b99-b4a9-3418191f1aa8 Co-authored-by: AlexLipp <10188895+AlexLipp@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add ScottishWater class for event duration monitoring
Add ScottishWater WaterCompany class
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scottish Water recently released a public near-real-time EDM API. This PR adds a
ScottishWatersubclass ofWaterCompanyto match the existing pattern for all other supported companies.Key differences from existing companies
GET /overflow-event-monitoring/v1/near-real-time) returns{"results": [...]}rather than the ArcGISfeatures[].attributesstructure, so_fetch_current_status_dfis overridden entirely.DISCHARGE_OVERFLOW_LOCATION_X/Yin OSGB36 already._parse_datetimehelper strips tzinfo for consistency with how other companies handle naive datetimes.13→Discharge(currently overflowing)14→NoDischarge+discharge_in_last_48h=True(recent overflow)15→NoDischarge(no overflow; checksOVERFLOW_END_DATETIMEfor 48h window)16→Offline(no data)_fetch_monitor_history/set_all_historiesare stubs, matching companies likeAnglianWaterandNorthumbrianWater.D8_FILE_URLandD8_FILE_HASHare set to"PLACEHOLDER"— update once the Scotland D8 file is uploaded to Zenodo. The corresponding test'scheck_watercompany()call is commented out until then.Usage
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
api.scottishwater.co.uk/home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js(dns block)zenodo.org/home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js(dns block)/usr/bin/curl curl -s REDACTED(dns block)/usr/bin/curl curl -s --max-time 10 REDACTED(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.