chore(dashboard): remove dead STL-serving route#59
Open
AlienWalker1995 wants to merge 1 commit into
Open
Conversation
The /stl/{filename} route (serve_stl) and its mimetypes/.stl + FileResponse
plumbing were added in #52 but no dashboard frontend references /stl/ or .stl —
STL artifacts are delivered via Hermes Deliverable Mode + Discord, not the
dashboard. Removing the unused route, its only-use imports (mimetypes,
FileResponse), and the leftover untracked sample STLs under static/stl/ so the
code matches the actual delivery path.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the unused
/stl/{filename}route (serve_stl) from the dashboard, along with its only-use plumbing:import mimetypes+mimetypes.add_type(..., .stl)from fastapi.responses import FileResponse+ its single call sitedashboard/static/stl/Why
The route was added in #52 but nothing in the dashboard frontend references
/stl/or.stl(grep of all non-Python dashboard files returns no matches). STL artifacts (e.g. Gridfinity bins) are delivered via Hermes Deliverable Mode + Discord pass-through, not the dashboard. The route was dead code and thestatic/stl/files were untracked cruft — both contradicted the actual delivery path.This brings the dashboard in line with reality (no dead code, one delivery path).
Validation
python -m py_compile dashboard/app.py→ OKmimetypes|FileResponse|serve_stl|STL_DIRinapp.py→ no remaining references🤖 Generated with Claude Code