Add wxEVT_CHAR_HOOK event type - #185
Open
trypsynth wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
wxEVT_CHAR_HOOK is the standard wxWidgets mechanism for catching a keyboard shortcut at the level of a dialog or frame regardless of which child control currently has focus. A plain KEY_DOWN binding on the top level window only fires when that window itself has focus, not when a child control inside it does, which makes it unsuitable for implementing shortcuts like closing a dialog with Cmd+W. CHAR_HOOK fires before normal key routing and is delivered to the top level window's handler chain first, so it does not have this limitation.
Test plan