add viskores rotational and linear extrusion - #1766
Open
nicolemarsaglia wants to merge 12 commits into
Open
Conversation
Mark inline methods with explicit 'inline' keyword to prevent symbol duplication when both vtkh_core.dll and vtkh_filters.dll export the Error class. This resolves linker error LNK2005 for Error constructor and other inline methods that were being defined in multiple DLLs when both were built with ASCENT_EXPORTS_FLAG. The explicit 'inline' keyword ensures these symbols are properly inlined at compile time and not duplicated across translation units in different DLLs. Fixes Windows build failure: fatal error LNK1169 in vtkh_filters.vcxproj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.