Conversation
|
@AltSysrq , this does most of what we described. There's three main issues with it:
|
AltSysrq
left a comment
There was a problem hiding this comment.
There's file mode changes in the output I don't quite understand.
Can you elaborate?
panics …
LoggerImpl
I didn't think there were any non-catastrophic situations where the exitsing code would panic like that, and I didn't see any situations where your new code would cause that?
Most of the specific subtypes of conflict log messages don't appear in the log output.
I'm fine with saying YAGNI on this.
Co-authored-by: Jason Lingle <jason@lin.gl>
e.g., at line of 335 of test/previous-outputs/1.0.1.json, there's a mode change from 384 to 33152.
Hm, taking a second look, not panics, but things that are returned as errors rather than being logged. This applies to most of the errors from |
That was actually a bug in |
Could that just be handled specially here? |
Closes #7.