Added support for gs:// links in Iceberg metadata #1311
Closed
+62
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds support for gs storage type when using it in GCS in S3-compatible XML API. Additionally, a NoSignCredentials was added in case GCS bucket is open and NOSIGN should be added to the request.
If `storage_endpoint` was set during `DataLakeCatalog` creation (e.g. when using GCS in S3-compatible mode), `data_location` is populated with a `https://` link. When `endpoint` is stripped from it, there is still a leading slash in `data_location`, which makes the next `if` statement falsy and causes the query to fail. This commit fixes that by removing the leading slash if `data_location` starts with it after `endpoint` is stripped.
Collaborator
Author
|
Closing in favor of #1318 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally, it fixes the
DataLakeLocationin casestorage_endpointwas provided.Fixes #1199
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Added support for
gs://links in Iceberg metadataCI/CD Options
Exclude tests:
Regression jobs to run: