Skip to content

Conversation

@olemartinorg
Copy link
Contributor

@olemartinorg olemartinorg commented Feb 6, 2026

Description

This updates e2e/Cypress tests to work with the changes in: https://altinn.studio/repos/ttd/service-task/pulls/1

Related Issue(s)

  • closes #{issue number}

Verification/QA

  • Manual functionality testing
    • I have tested these changes manually
    • Creator of the original issue (or service owner) has been contacted for manual testing (or will be contacted when released in alpha)
    • No testing done/necessary
  • Automated tests
    • Unit test(s) have been added/updated
    • Cypress E2E test(s) have been added/updated
    • No automatic tests are needed here (no functional changes/additions)
    • I want someone to help me make some tests
  • UU/WCAG (follow these guidelines until we have our own)
    • I have tested with a screen reader/keyboard navigation/automated wcag validator
    • No testing done/necessary (no DOM/visual changes)
    • I want someone to help me perform accessibility testing
  • User documentation @ altinn-studio-docs
    • Has been added/updated
    • No functionality has been changed/added, so no documentation is needed
    • I will do that later/have created an issue
  • Support in Altinn Studio
    • Issue(s) created for support in Studio
    • This change/feature does not require any changes to Altinn Studio
  • Sprint board
    • The original issue (or this PR itself) has been added to the Team Apps project and to the current sprint board
    • I don't have permissions to do that, please help me out
  • Labels
    • I have added a kind/* and backport* label to this PR for proper release notes grouping
    • I don't have permissions to add labels, please help me out

Summary by CodeRabbit

  • Tests
    • Enhanced end-to-end test coverage for service task workflows, including validation of PDF generation for subforms.
    • Updated test data and assertions to reflect current functionality and improve test reliability.

@olemartinorg olemartinorg self-assigned this Feb 6, 2026
@olemartinorg olemartinorg added ignore-for-release Pull requests to be ignored in release notes backport-ignore This PR is a new feature and should not be cherry-picked onto release branches labels Feb 6, 2026
@olemartinorg olemartinorg added the taskforce/next Issues that belongs to the named task-force label Feb 6, 2026
@olemartinorg olemartinorg moved this to 🔎 In review in Team Altinn Studio Feb 6, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 6, 2026

📝 Walkthrough

Walkthrough

E2E integration test for service tasks updated with revised test identifiers and adjusted assertions, including changing a simulated failure filter identifier, renaming a subform textbox reference, and increasing expected PDF link count from 2 to 3.

Changes

Cohort / File(s) Summary
E2E Service Task Test
test/e2e/integration/service-task/service-task.ts
Updated simulated failure filter from 'Fail' to 'SimulatedFailure', changed subform textbox name from 'Subform tekstfelt' to 'Test 1', and adjusted end-of-flow PDF link assertions from 2 to 3 with additional subform PDF verification.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Fixes for ttd/service-task tests' directly describes the main change—updates to e2e/Cypress tests—and is concise and clear.
Description check ✅ Passed The description includes required sections (Description, Related Issue, and Verification/QA checklist) with appropriate checkboxes marked, though the issue number is left as a placeholder and some sections like commit message tracking are not present.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/service-task-tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@olemartinorg olemartinorg moved this from 🔎 In review to ⚠️ Blocked in Team Altinn Studio Feb 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-ignore This PR is a new feature and should not be cherry-picked onto release branches ignore-for-release Pull requests to be ignored in release notes taskforce/next Issues that belongs to the named task-force

Projects

Status: ⚠️ Blocked

Development

Successfully merging this pull request may close these issues.

2 participants