Repository navigation
fix(terminal): preserve semantic coloring across wraps and scrolling - #809
Merged
AnalyseDeCircuit merged 2 commits intoNov 17, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Soft-wrapped output could change semantic colors as the viewport moved because classification lost off-screen logical-line context. This change captures complete wrapped-line context and maps classifications back to visible cells, including wide and combining characters, smooth-scroll overscan, and folded views.
Unchanged contexts reuse snapshot-owned, zeroizing text after validating row identities, content revisions, and wrap boundaries. Layout cache hits skip classification; oversized classifications remain transient without clearing ordinary cached entries. Span eviction is incremental, and candidate overlap checks avoid quadratic scans on long output.
Validation:
Local performance measurements: an unchanged 2.4 MB wrapped-line snapshot dropped from approximately 8–9 ms to 0.09 ms; scrolling snapshots measured approximately 0.23 ms. Input parsing and end-to-end write benchmarks remained broadly stable in quick samples.
A trial merge against the current upstream main completed without conflicts.