Fixing highlighting for NEWLINE.#7
Open
Kaganis wants to merge 2 commits intoAnduh:mainfrom
Open
Conversation
Changed %%NEWLINE%% to the correct %NEWLINE%.
Changed %%NEWLINE%% to the correct %NEWLINE%.
Owner
|
Yeah seems simple like a simple fix, that should work. I haven't updated the plugin in years and been meaning to give it a minor bump this year, but the time files by. I'll try to find the time in early Januaty & go through how the plugins are updated and try get this added. |
Author
|
Awesome, Ta! :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original highlighting is for %%NEWLINE%%, but the actual Roll20 function is %NEWLINE% (only one pair of %). The double will just produce something like this:
%
%
Hopefully I've hacked together the correction correctly... I'll admit I don't really know JSON, and this is my first attempt at a pull request. But the change looked easy so I thought I'd give it a go, hopefully make it as easy as possible to apply the fix.... :-)