[codex] v3.28 follow-up: fix position hysteresis and voice cleanup#10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
get_position()frame-stable so repeated same-frame reads do not consume the left/right/ahead hysteresis budgetframe_tagandframe_widththrough threat scoring so side-pass boosts use the same cached zone as the rest of the framedist_mparameter from_select_voice_message()so the helper matches its real interfacePiperVoice.synthesize_alert_to_file()honor the instance_alert_cache_enabledflag instead of ignoring it_copy_to_temp()fails mid-copy174 passedvalidation countWhy
Claude's review surfaced a real field-impacting bug:
get_position()mutates hysteresis state, but it was being called 4-6 times in one video frame. That meant objects near a zone boundary could switch from left/right to ahead faster than intended.The other changes are cleanup and correctness fixes around the alert helper path so the code matches the behavior the tests and runtime expect.
Validation
python -m py_compile raspberry_pi/yolo_realsense_navigation.py tests/test_blindnav_v326.pypytest tests/test_blindnav.py tests/test_blindnav_v326.py -q174 passed