empty: equal empty slice support#269
Open
NathanBaulch wants to merge 1 commit into
Open
Conversation
d52ad4b to
cca869e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm completely new to Go code analysis but thought I'd give this a try.
I have a project where contributors often assert values are equal to empty slices. I'd like these to use
assert.Emptyfor more meaningful failure messages and general consistency.There are a couple of complications to consider however. If the actual value is a nil slice then
assert.Emptyis more permissive sinceassert.Equalwould have failed. This is not a distinction I personally care about, but I'm not sure how conservative this linter aims to be. See stretchr/testify#1141.Also, if the types don't match then that would also produce a false-success.
It looks easy enough to add a type check with something like
types.Identical(pass.TypesInfo.TypeOf(a), pass.TypesInfo.TypeOf(b))but the other equals based empty checks don't do this so I left it out. Perhaps they should?