Add redundant-error-assertion checker for implied assert.Error / require.Error assertions#310
Open
mmorel-35 wants to merge 3 commits into
Open
Add redundant-error-assertion checker for implied assert.Error / require.Error assertions#310mmorel-35 wants to merge 3 commits into
redundant-error-assertion checker for implied assert.Error / require.Error assertions#310mmorel-35 wants to merge 3 commits into
Conversation
30232fa to
ec75d69
Compare
e607c86 to
97d8457
Compare
redundant-assert checker for implied assert.Error assertionsredundant-error-assertion checker for implied assert.Error / require.Error assertions
1539e42 to
9c8ca45
Compare
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
…date related tests Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
9c8ca45 to
c2da898
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new checker to catch redundant
assert.Error*/require.Error*calls when a stronger error assertion on the same error expression already exists in the same block. The goal is to remove duplicate signal and keep error assertions minimal, regardless of whether the code usesassertorrequire.New checker:
redundant-error-assertionast.BlockStmt.assert.Error*/require.Error*when paired with a stronger assertion on the same error expression:ErrorContains*ErrorIs*ErrorAs*EqualError*analysisutil.NodeString) for same-error detection, with reassignment safety checks preserved.Checker integration
redundant-error-assertionin checker priority order and enables it by default.Docs and examples
redundant-error-assertionto the README checker table.Analyzer test coverage
.go+.golden) for:assert.Error*+ stronger assertion on the same errorrequire.Error*+ stronger assertion on the same errorassert/requirecasesassObj.Error)reqObj.Error)