Add ErrorContains checker#319
Closed
thespags wants to merge 2 commits into
Closed
Conversation
added 2 commits
June 21, 2026 21:11
Owner
|
Duplicate of #294 |
Author
|
Thanks @Antonboom that MR is much more complete. Do you know when you'll have a chance to review it? |
Owner
|
I will review and take into accounts all MRs, but in milestones order. If you have some proofs, that ErrorContains is really useful, I can think to include it in the nearest release from my PoV, and Contains and ErrorContanis are not proper way to handle error, so we should not suggest any of these |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another case of users using
require.Contains(t, err.Error, ...)instead of the built in testifyrequire.ErrorContains(t, err, ...)